Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 2541353006: Making offline previews freshness configurable (Closed)

Created:
4 years ago by RyanSturm
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Making offline previews freshness configurable This makes the freshness (e.g. the amount of time since download that the page may be shown as a preview) of offline previews controllable as a field trial param. This also sets the default back to 7 days, which was changed during the offline page refactor that moved the code from the UI thread to the IO thread. BUG=669093 Review-Url: https://codereview.chromium.org/2537563002 Cr-Commit-Position: refs/heads/master@{#435251} (cherry picked from commit e42c5acc8c61a87e6a72352d2428b3f477bd73c1) Committed: https://chromium.googlesource.com/chromium/src/+/426a071edcb4b14719869f95bd533ea6081c1d0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M chrome/browser/android/offline_pages/offline_page_request_job.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/previews/core/previews_experiments.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/previews/core/previews_experiments.cc View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
RyanSturm
4 years ago (2016-12-02 21:15:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
426a071edcb4b14719869f95bd533ea6081c1d0d.

Powered by Google App Engine
This is Rietveld 408576698