Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2541353003: TaskScheduler: Initialize TaskTraits with the priority of the current thread. (Closed)

Created:
4 years ago by fdoray
Modified:
4 years ago
Reviewers:
robliao, danakj, gab
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TaskScheduler: Initialize TaskTraits with the priority of the current thread. BUG=553459 TBR=danakj@chromium.org Committed: https://crrev.com/c2c1c4f3a36de0ef7319d15896dfb04feea63485 Cr-Commit-Position: refs/heads/master@{#435965}

Patch Set 1 #

Total comments: 3

Patch Set 2 : improve comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -3 lines) Patch
M base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/task_scheduler/task_traits.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M base/task_scheduler/task_traits.cc View 2 chunks +2 lines, -1 line 0 comments Download
A base/task_scheduler/task_traits_unittest.cc View 1 chunk +32 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (10 generated)
fdoray
PTAL
4 years ago (2016-12-01 20:58:51 UTC) #2
gab
lgtm w/ comment https://codereview.chromium.org/2541353003/diff/1/base/task_scheduler/task_traits.h File base/task_scheduler/task_traits.h (right): https://codereview.chromium.org/2541353003/diff/1/base/task_scheduler/task_traits.h#newcode85 base/task_scheduler/task_traits.h:85: // Tasks that require stricter guarantees ...
4 years ago (2016-12-01 22:10:50 UTC) #3
robliao
lgtm https://codereview.chromium.org/2541353003/diff/1/base/task_scheduler/task_traits.h File base/task_scheduler/task_traits.h (right): https://codereview.chromium.org/2541353003/diff/1/base/task_scheduler/task_traits.h#newcode85 base/task_scheduler/task_traits.h:85: // Tasks that require stricter guarantees should highlight ...
4 years ago (2016-12-01 22:26:45 UTC) #4
fdoray
https://codereview.chromium.org/2541353003/diff/1/base/task_scheduler/task_traits.h File base/task_scheduler/task_traits.h (right): https://codereview.chromium.org/2541353003/diff/1/base/task_scheduler/task_traits.h#newcode85 base/task_scheduler/task_traits.h:85: // Tasks that require stricter guarantees should highlight those ...
4 years ago (2016-12-02 13:41:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541353003/20001
4 years ago (2016-12-02 13:42:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/317375)
4 years ago (2016-12-02 13:49:40 UTC) #10
fdoray
TBR danakj for base/build.gn
4 years ago (2016-12-02 16:26:18 UTC) #12
fdoray
4 years ago (2016-12-02 16:26:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541353003/20001
4 years ago (2016-12-02 16:27:00 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-02 17:34:15 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-02 17:36:28 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c2c1c4f3a36de0ef7319d15896dfb04feea63485
Cr-Commit-Position: refs/heads/master@{#435965}

Powered by Google App Engine
This is Rietveld 408576698