Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2541333002: ChromeOS MD-OOBE: "Back" button for EULA screen. (Closed)

Created:
4 years ago by Alexander Alekseev
Modified:
4 years ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS MD-OOBE: "Back" button for EULA screen. This CL adds "Back" button to EULA screen. BUG=604119 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3a8630a473614699e9f9b2a8643a1e09a4f79a8e Cr-Commit-Position: refs/heads/master@{#435785}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Total comments: 4

Patch Set 4 : Update after review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_eula.css View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_eula.html View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_eula.js View 1 2 3 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Alexander Alekseev
Please review.
4 years ago (2016-12-01 08:51:21 UTC) #3
xiyuan
https://codereview.chromium.org/2541333002/diff/40001/chrome/browser/resources/chromeos/login/oobe_eula.css File chrome/browser/resources/chromeos/login/oobe_eula.css (right): https://codereview.chromium.org/2541333002/diff/40001/chrome/browser/resources/chromeos/login/oobe_eula.css#newcode43 chrome/browser/resources/chromeos/login/oobe_eula.css:43: padding-right: 18px; padding-right -> -webkit-padding-end to be rtl friendly. ...
4 years ago (2016-12-01 17:40:54 UTC) #8
Alexander Alekseev
https://codereview.chromium.org/2541333002/diff/40001/chrome/browser/resources/chromeos/login/oobe_eula.css File chrome/browser/resources/chromeos/login/oobe_eula.css (right): https://codereview.chromium.org/2541333002/diff/40001/chrome/browser/resources/chromeos/login/oobe_eula.css#newcode43 chrome/browser/resources/chromeos/login/oobe_eula.css:43: padding-right: 18px; On 2016/12/01 17:40:54, xiyuan wrote: > padding-right ...
4 years ago (2016-12-01 23:20:08 UTC) #9
xiyuan
lgtm
4 years ago (2016-12-01 23:21:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541333002/60001
4 years ago (2016-12-01 23:23:17 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-02 00:18:51 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-02 00:21:42 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3a8630a473614699e9f9b2a8643a1e09a4f79a8e
Cr-Commit-Position: refs/heads/master@{#435785}

Powered by Google App Engine
This is Rietveld 408576698