Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 254133002: Remove support for Document.createEvent() without argument (Closed)

Created:
6 years, 7 months ago by Inactive
Modified:
6 years, 7 months ago
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, rwlbuis
Visibility:
Public.

Description

Remove support for Document.createEvent() without argument Remove support for Document.createEvent() without argument. This only worked for SVG documents and for historical reasons. The UseCounter shows that the feature is used by less than 0.0001% of pages. The new behavior matches the specification: http://dom.spec.whatwg.org/#dom-document-createevent It also matches the behavior of Firefox 28 and IE11. Intent to remove thread on blink-dev: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/INrADzxchrg R=arv@chromium.org, eseidel@chromium.org BUG=238366 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173314

Patch Set 1 #

Patch Set 2 : Add layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -15 lines) Patch
A LayoutTests/svg/dom/document-createEvent-mandatory-arg.html View 1 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/svg/dom/document-createEvent-mandatory-arg-expected.txt View 1 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/dom/Document.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Inactive
6 years, 7 months ago (2014-04-30 13:36:29 UTC) #1
arv (Not doing code reviews)
Maybe add a test?
6 years, 7 months ago (2014-04-30 13:40:40 UTC) #2
Inactive
On 2014/04/30 13:40:40, arv wrote: > Maybe add a test? Ok, I hesitated.
6 years, 7 months ago (2014-04-30 14:05:04 UTC) #3
Inactive
On 2014/04/30 13:40:40, arv wrote: > Maybe add a test? Done.
6 years, 7 months ago (2014-04-30 14:20:49 UTC) #4
arv (Not doing code reviews)
LGTM
6 years, 7 months ago (2014-04-30 15:03:06 UTC) #5
Inactive
The intent to remove received enough support on the mailing list. Could an API OWNER ...
6 years, 7 months ago (2014-05-05 14:44:57 UTC) #6
eseidel
lgtm
6 years, 7 months ago (2014-05-05 15:29:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/254133002/20001
6 years, 7 months ago (2014-05-05 15:29:31 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 15:39:54 UTC) #9
Message was sent while issue was closed.
Change committed as 173314

Powered by Google App Engine
This is Rietveld 408576698