Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: ui/views/controls/label_unittest.cc

Issue 2541313002: RenderTextHarfBuzz: Add support for multi line text selection. (Closed)
Patch Set: -- Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/label_unittest.cc
diff --git a/ui/views/controls/label_unittest.cc b/ui/views/controls/label_unittest.cc
index e8fa4f95826e023d4e6d235e6fba9b914a11d2cb..cf74d57ea1cd797a1ba8e8e287d54892ad570766 100644
--- a/ui/views/controls/label_unittest.cc
+++ b/ui/views/controls/label_unittest.cc
@@ -820,13 +820,9 @@ TEST_F(LabelSelectionTest, Selectable) {
ASSERT_TRUE(label()->SetSelectable(true));
EXPECT_TRUE(label()->selectable());
- // Verify that making a label multiline causes the label to not support text
+ // Verify that making a label multiline still causes the label to support text
// selection.
label()->SetMultiLine(true);
- EXPECT_FALSE(label()->selectable());
-
- label()->SetMultiLine(false);
- ASSERT_TRUE(label()->SetSelectable(true));
EXPECT_TRUE(label()->selectable());
// Verify that obscuring the label text causes the label to not support text

Powered by Google App Engine
This is Rietveld 408576698