RenderTextHarfBuzz: Add support for multi line text selection.

ui/views/controls/label_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/label.h"
 
 #include <stddef.h>
 
 #include "base/command_line.h"
 #include "base/i18n/rtl.h"
@@ skipping 10 matching lines @@
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/render_text.h"
 #include "ui/gfx/switches.h"
 #include "ui/strings/grit/ui_strings.h"
 #include "ui/views/border.h"
 #include "ui/views/test/focus_manager_test.h"
 #include "ui/views/test/views_test_base.h"
 #include "ui/views/widget/widget.h"
 
 using base::ASCIIToUTF16;
+using base::WideToUTF16;
 
 #define EXPECT_STR_EQ(ascii, utf16) EXPECT_EQ(ASCIIToUTF16(ascii), utf16)
 
 namespace views {
 
 namespace {
 
 #if defined(OS_MACOSX)
 const int kControlCommandModifier = ui::EF_COMMAND_DOWN;
 #else
@@ skipping 131 matching lines @@
     PerformMousePress(point, extra_flags);
     PerformMouseRelease(point);
   }
 
   void PerformMouseDragTo(const gfx::Point& point) {
     ui::MouseEvent drag(ui::ET_MOUSE_DRAGGED, point, point,
                         ui::EventTimeForNow(), ui::EF_LEFT_MOUSE_BUTTON, 0);
     label()->OnMouseDragged(drag);
   }
 
-  gfx::Point GetCursorPoint(int cursor_pos) {
-    return label()
-        ->GetRenderTextForSelectionController()
-        ->GetCursorBounds(gfx::SelectionModel(cursor_pos, gfx::CURSOR_FORWARD),
-                          false)
-        .origin();
+  gfx::Point GetCursorPoint(int index, bool rtl = false) {

[msw, 2016/12/13 03:04:56]

nit: can we check if the text is rtl instead of passing in a flag?

[karandeepb, 2016/12/16 02:58:38]

Done.

+    label()->GetRenderTextForSelectionController()->EnsureLayout();
+    const std::vector<gfx::Rect> bounds =
+        label()->GetRenderTextForSelectionController()->GetSubstringBounds(
+            gfx::Range(index, index + 1));
+    DCHECK_EQ(1u, bounds.size());
+    // Return Point corresponding to the leading edge of the character.
+    return gfx::Point(rtl ? bounds[0].right() - 1 : bounds[0].x() + 1,
+                      bounds[0].y() + bounds[0].height() / 2);
+  }
+
+  size_t GetLineCount() {
+    label()->GetRenderTextForSelectionController()->EnsureLayout();
+    return label()->GetRenderTextForSelectionController()->lines().size();
   }
 
   base::string16 GetSelectedText() { return label()->GetSelectedText(); }
 
   ui::test::EventGenerator* event_generator() { return event_generator_.get(); }
 
   bool IsMenuCommandEnabled(int command_id) {
     return label()->IsCommandIdEnabled(command_id);
   }
 
@@ skipping 615 matching lines @@
   EXPECT_LT(label()->font_list().GetHeight(), focus_bounds.height());
 }
 
 TEST_F(LabelSelectionTest, Selectable) {
   // By default, labels don't support text selection.
   EXPECT_FALSE(label()->selectable());
 
   ASSERT_TRUE(label()->SetSelectable(true));
   EXPECT_TRUE(label()->selectable());
 
-  // Verify that making a label multiline causes the label to not support text
+  // Verify that making a label multiline still causes the label to support text
   // selection.
   label()->SetMultiLine(true);
-  EXPECT_FALSE(label()->selectable());
-
-  label()->SetMultiLine(false);
-  ASSERT_TRUE(label()->SetSelectable(true));
   EXPECT_TRUE(label()->selectable());
 
   // Verify that obscuring the label text causes the label to not support text
   // selection.
   label()->SetObscured(true);
   EXPECT_FALSE(label()->selectable());
 }
 
 // Verify that labels supporting text selection get focus on clicks.
 TEST_F(LabelSelectionTest, FocusOnClick) {
@@ skipping 39 matching lines @@
   widget()->GetFocusManager()->AdvanceFocus(false);
   EXPECT_EQ(label(), GetFocusedView());
 }
 
 // Verify label text selection behavior on double and triple clicks.
 TEST_F(LabelSelectionTest, DoubleTripleClick) {
   label()->SetText(ASCIIToUTF16("Label double click"));
   label()->SizeToPreferredSize();
   ASSERT_TRUE(label()->SetSelectable(true));
 
-  PerformClick(gfx::Point());
+  PerformClick(GetCursorPoint(0));
   EXPECT_TRUE(GetSelectedText().empty());
 
   // Double clicking should select the word under cursor.
-  PerformClick(gfx::Point(), ui::EF_IS_DOUBLE_CLICK);
+  PerformClick(GetCursorPoint(0), ui::EF_IS_DOUBLE_CLICK);
   EXPECT_STR_EQ("Label", GetSelectedText());
 
   // Triple clicking should select all the text.
-  PerformClick(gfx::Point());
+  PerformClick(GetCursorPoint(0));
   EXPECT_EQ(label()->text(), GetSelectedText());
 
   // Clicking again should alternate to double click.
-  PerformClick(gfx::Point());
+  PerformClick(GetCursorPoint(0));
   EXPECT_STR_EQ("Label", GetSelectedText());
 
   // Clicking at another location should clear the selection.
   PerformClick(GetCursorPoint(8));
   EXPECT_TRUE(GetSelectedText().empty());
   PerformClick(GetCursorPoint(8), ui::EF_IS_DOUBLE_CLICK);
   EXPECT_STR_EQ("double", GetSelectedText());
 }
 
 // Verify label text selection behavior on mouse drag.
 TEST_F(LabelSelectionTest, MouseDrag) {
   label()->SetText(ASCIIToUTF16("Label mouse drag"));
   label()->SizeToPreferredSize();
   ASSERT_TRUE(label()->SetSelectable(true));
 
   PerformMousePress(GetCursorPoint(5));
-  PerformMouseDragTo(gfx::Point());
+  PerformMouseDragTo(GetCursorPoint(0));
   EXPECT_STR_EQ("Label", GetSelectedText());
 
   PerformMouseDragTo(GetCursorPoint(8));
   EXPECT_STR_EQ(" mo", GetSelectedText());
 
-  PerformMouseDragTo(gfx::Point(200, 0));
-  PerformMouseRelease(gfx::Point(200, 0));
+  PerformMouseDragTo(gfx::Point(200, GetCursorPoint(0).y()));
+  PerformMouseRelease(gfx::Point(200, GetCursorPoint(0).y()));
   EXPECT_STR_EQ(" mouse drag", GetSelectedText());
 
   event_generator()->PressKey(ui::VKEY_C, kControlCommandModifier);
   EXPECT_STR_EQ(" mouse drag", GetClipboardText(ui::CLIPBOARD_TYPE_COPY_PASTE));
 }
 
+TEST_F(LabelSelectionTest, MouseDragMultilineLTR) {
+  label()->SetMultiLine(true);
+  label()->SetText(ASCIIToUTF16("abcd\nefgh"));
+  label()->SizeToPreferredSize();
+  ASSERT_TRUE(label()->SetSelectable(true));
+  ASSERT_EQ(2u, GetLineCount());
+
+  PerformMousePress(GetCursorPoint(2));
+  PerformMouseDragTo(GetCursorPoint(0));
+  EXPECT_STR_EQ("ab", GetSelectedText());
+
+  PerformMouseDragTo(GetCursorPoint(7));
+  EXPECT_STR_EQ("cd\nef", GetSelectedText());
+
+  PerformMouseDragTo(gfx::Point(-5, GetCursorPoint(6).y()));
+  EXPECT_STR_EQ("cd\n", GetSelectedText());
+
+  PerformMouseDragTo(gfx::Point(100, GetCursorPoint(6).y()));
+  EXPECT_STR_EQ("cd\nefgh", GetSelectedText());
+
+  PerformMouseDragTo(gfx::Point(GetCursorPoint(3).x(), -5));
+  EXPECT_STR_EQ(gfx::RenderText::kDragToEndIfOutsideVerticalBounds ? "ab" : "c",
+                GetSelectedText());
+
+  PerformMouseDragTo(gfx::Point(GetCursorPoint(7).x(), 100));
+  EXPECT_STR_EQ(gfx::RenderText::kDragToEndIfOutsideVerticalBounds ? "cd\nefgh"
+                                                                   : "cd\nef",
+                GetSelectedText());
+}
+
+TEST_F(LabelSelectionTest, MouseDragMultilineRTL) {
+  label()->SetMultiLine(true);
+  label()->SetText(WideToUTF16(L"\x5d0\x5d1\x5d2\n\x5d3\x5d4\x5d5"));
+  label()->SizeToPreferredSize();
+  ASSERT_TRUE(label()->SetSelectable(true));
+  ASSERT_EQ(2u, GetLineCount());
+
+  PerformMousePress(GetCursorPoint(1, true));
+  PerformMouseDragTo(GetCursorPoint(0, true));
+  EXPECT_EQ(WideToUTF16(L"\x5d0"), GetSelectedText());
+
+  PerformMouseDragTo(GetCursorPoint(6, true));
+  EXPECT_EQ(WideToUTF16(L"\x5d1\x5d2\n\x5d3\x5d4"), GetSelectedText());
+
+  PerformMouseDragTo(gfx::Point(-5, GetCursorPoint(6, true).y()));
+  EXPECT_EQ(WideToUTF16(L"\x5d1\x5d2\n\x5d3\x5d4\x5d5"), GetSelectedText());
+
+  PerformMouseDragTo(gfx::Point(100, GetCursorPoint(6, true).y()));
+  EXPECT_EQ(WideToUTF16(L"\x5d1\x5d2\n"), GetSelectedText());
+
+  PerformMouseDragTo(gfx::Point(GetCursorPoint(2, true).x(), -5));
+  EXPECT_EQ(gfx::RenderText::kDragToEndIfOutsideVerticalBounds
+                ? WideToUTF16(L"\x5d0")
+                : WideToUTF16(L"\x5d1"),
+            GetSelectedText());
+
+  PerformMouseDragTo(gfx::Point(GetCursorPoint(6, true).x(), 100));
+  EXPECT_EQ(gfx::RenderText::kDragToEndIfOutsideVerticalBounds
+                ? WideToUTF16(L"\x5d1\x5d2\n\x5d3\x5d4\x5d5")
+                : WideToUTF16(L"\x5d1\x5d2\n\x5d3\x5d4"),
+            GetSelectedText());
+}
+
 // Verify the initially selected word on a double click, remains selected on
 // mouse dragging.
 TEST_F(LabelSelectionTest, MouseDragWord) {
   label()->SetText(ASCIIToUTF16("Label drag word"));
   label()->SizeToPreferredSize();
   ASSERT_TRUE(label()->SetSelectable(true));
 
   PerformClick(GetCursorPoint(8));
   PerformMousePress(GetCursorPoint(8), ui::EF_IS_DOUBLE_CLICK);
   EXPECT_STR_EQ("drag", GetSelectedText());
 
-  PerformMouseDragTo(gfx::Point());
+  PerformMouseDragTo(GetCursorPoint(0));
   EXPECT_STR_EQ("Label drag", GetSelectedText());
 
-  PerformMouseDragTo(gfx::Point(200, 0));
-  PerformMouseRelease(gfx::Point(200, 0));
+  PerformMouseDragTo(gfx::Point(200, GetCursorPoint(0).y()));
+  PerformMouseRelease(gfx::Point(200, GetCursorPoint(0).y()));
   EXPECT_STR_EQ("drag word", GetSelectedText());
 }
 
 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
 // Verify selection clipboard behavior on text selection.
 TEST_F(LabelSelectionTest, SelectionClipboard) {
   label()->SetText(ASCIIToUTF16("Label selection clipboard"));
   label()->SizeToPreferredSize();
   ASSERT_TRUE(label()->SetSelectable(true));
 
   // Verify programmatic modification of selection, does not modify the
   // selection clipboard.
   label()->SelectRange(gfx::Range(2, 5));
   EXPECT_STR_EQ("bel", GetSelectedText());
   EXPECT_TRUE(GetClipboardText(ui::CLIPBOARD_TYPE_SELECTION).empty());
 
   // Verify text selection using the mouse updates the selection clipboard.
   PerformMousePress(GetCursorPoint(5));
-  PerformMouseDragTo(gfx::Point());
-  PerformMouseRelease(gfx::Point());
+  PerformMouseDragTo(GetCursorPoint(0));
+  PerformMouseRelease(GetCursorPoint(0));
   EXPECT_STR_EQ("Label", GetSelectedText());
   EXPECT_STR_EQ("Label", GetClipboardText(ui::CLIPBOARD_TYPE_SELECTION));
 }
 #endif
 
 // Verify that keyboard shortcuts for Copy and Select All work when a selectable
 // label is focused.
 TEST_F(LabelSelectionTest, KeyboardActions) {
   const base::string16 initial_text = ASCIIToUTF16("Label keyboard actions");
   label()->SetText(initial_text);
@@ skipping 56 matching lines @@
   label()->SetObscured(false);
 
   // For an empty label, both COPY and SELECT_ALL should be disabled.
   label()->SetText(base::string16());
   ASSERT_TRUE(label()->SetSelectable(true));
   EXPECT_FALSE(IsMenuCommandEnabled(IDS_APP_COPY));
   EXPECT_FALSE(IsMenuCommandEnabled(IDS_APP_SELECT_ALL));
 }
 
 }  // namespace views