[promises] Port ResolvePromise to TF

src/objects.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_OBJECTS_H_
 #define V8_OBJECTS_H_
 
 #include <iosfwd>
 #include <memory>
 
@@ skipping 8894 matching lines @@
   // or deferred registered.
   // 2) Object -- There is a single Callable directly attached to the
   // fulfill_reactions, reject_reactions and the deferred JSObject is
   // directly attached to the deferred field.
   // 3) FixedArray -- There is more than one callback and deferred
   // attached to a FixedArray.
   DECL_ACCESSORS(deferred, Object)
   DECL_ACCESSORS(fulfill_reactions, Object)
   DECL_ACCESSORS(reject_reactions, Object)
 
+  // TODO(gsathya): Use a BitField
+  DECL_INT_ACCESSORS(has_handler)

[jgruber, 2016/12/07 12:59:38]

Please add a comment for content meaning and possible values.

BTW, you can use the DECL_BOOLEAN_ACCESSORS convenience functions if you haven't
seen them yet.

[Igor Sheludko, 2016/12/07 16:23:52]

+1. Please turn this into smi "flag" field + boolean "has_handler" accessor as
Jakob suggested. It will make caller code look nicer.

[gsathya, 2016/12/08 05:18:15]

Done.

+
   static const char* Status(int status);
 
   DECLARE_CAST(JSPromise)
 
   // Dispatched behavior.
   DECLARE_PRINTER(JSPromise)
   DECLARE_VERIFIER(JSPromise)
 
   // Layout description.
   static const int kStatusOffset = JSObject::kHeaderSize;
   static const int kResultOffset = kStatusOffset + kPointerSize;
   static const int kDeferredOffset = kResultOffset + kPointerSize;
   static const int kFulfillReactionsOffset = kDeferredOffset + kPointerSize;
   static const int kRejectReactionsOffset =
       kFulfillReactionsOffset + kPointerSize;
-  static const int kSize = kRejectReactionsOffset + kPointerSize;
+  static const int kHasHandlerOffset = kRejectReactionsOffset + kPointerSize;
+  static const int kSize = kHasHandlerOffset + kPointerSize;
 };
 
 // Regular expressions
 // The regular expression holds a single reference to a FixedArray in
 // the kDataOffset field.
 // The FixedArray contains the following data:
 // - tag : type of regexp implementation (not compiled yet, atom or irregexp)
 // - reference to the original source string
 // - reference to the original flag string
 // If it is an atom regexp
@@ skipping 3047 matching lines @@
     }
     return value;
   }
 };
 
 
 }  // NOLINT, false-positive due to second-order macros.
 }  // NOLINT, false-positive due to second-order macros.
 
 #endif  // V8_OBJECTS_H_