Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2541223006: [ios] Adds resources for the infobar. (Closed)

Created:
4 years ago by rohitrao (ping after 24h)
Modified:
4 years ago
Reviewers:
sczs, sdefresne, justincohen
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds resources for the infobar. BUG=666732 Committed: https://crrev.com/3aece464226cc398b6b9df2e1d2639cd96e8fba6 Cr-Commit-Position: refs/heads/master@{#435973}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
A ios/chrome/browser/ui/infobars/BUILD.gn View 1 chunk +28 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/infobars/resources/infobar_close.png View Binary file 0 comments Download
A ios/chrome/browser/ui/infobars/resources/infobar_close@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/infobars/resources/infobar_close@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/infobars/resources/infobar_downloading.png View Binary file 0 comments Download
A ios/chrome/browser/ui/infobars/resources/infobar_downloading@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/infobars/resources/infobar_downloading@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/infobars/resources/infobar_popup_blocker.png View Binary file 0 comments Download
A ios/chrome/browser/ui/infobars/resources/infobar_popup_blocker@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/infobars/resources/infobar_popup_blocker@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/infobars/resources/infobar_shadow.png View Binary file 0 comments Download
A ios/chrome/browser/ui/infobars/resources/infobar_shadow@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/infobars/resources/infobar_update.png View Binary file 0 comments Download
A ios/chrome/browser/ui/infobars/resources/infobar_update@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/infobars/resources/infobar_update@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/infobars/resources/infobar_warning.png View Binary file 0 comments Download
A ios/chrome/browser/ui/infobars/resources/infobar_warning@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/infobars/resources/infobar_warning@3x.png View Binary file 0 comments Download

Messages

Total messages: 15 (9 generated)
rohitrao (ping after 24h)
Please review and also double-check my plan for moving these resources: 1) Write CLs like ...
4 years ago (2016-12-02 00:40:07 UTC) #4
justincohen
LGTM
4 years ago (2016-12-02 17:35:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541223006/1
4 years ago (2016-12-02 17:58:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 18:03:34 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3aece464226cc398b6b9df2e1d2639cd96e8fba6 Cr-Commit-Position: refs/heads/master@{#435973}
4 years ago (2016-12-02 18:06:07 UTC) #14
sdefresne
4 years ago (2016-12-05 15:02:52 UTC) #15
Message was sent while issue was closed.
lgtm and sgtm

Powered by Google App Engine
This is Rietveld 408576698