chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h - Issue 2541173003: Allow navigation while a JavaScript dialog is up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h

Issue 2541173003: Allow navigation while a JavaScript dialog is up. (Closed)

Patch Set: test cleaner Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc ('k') | chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h

diff --git a/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h

index 95d8b6cf2403c42d1d69f6da62acbcfd3a865db9..6eaf754b6e3c5d512ac357369b50280d32989d52 100644

--- a/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h

+++ b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h

@@ -58,6 +58,11 @@ class JavaScriptDialogTabHelper

// WebContentsObserver:

void WasHidden() override;

+ void DidStartNavigation(

+ content::NavigationHandle* navigation_handle) override;

+ void DidStartNavigationToPendingEntry(

+ const GURL& url,

+ content::ReloadType reload_type) override;

// BrowserListObserver:

void OnBrowserSetLastActive(Browser* browser) override;