Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: third_party/WebKit/Source/core/editing/iterators/TextIteratorTest.cpp

Issue 2541163003: Fix TextIterator's behavior with first-letter (Closed)
Patch Set: Mon Dec 5 18:00:48 JST 2016 Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/iterators/TextIteratorTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/iterators/TextIteratorTest.cpp b/third_party/WebKit/Source/core/editing/iterators/TextIteratorTest.cpp
index 947c2e089b8d51d2e37903eccde624e2f6b1be19..b6fdfa92020f32feda6afcdda83cfdb15abca1f1 100644
--- a/third_party/WebKit/Source/core/editing/iterators/TextIteratorTest.cpp
+++ b/third_party/WebKit/Source/core/editing/iterators/TextIteratorTest.cpp
@@ -640,4 +640,98 @@ TEST_F(TextIteratorTest, PreserveOnlyLeadingSpace) {
TextIteratorEmitsImageAltText));
}
+TEST_F(TextIteratorTest, StartAtFirstLetter) {
+ setBodyContent("<style>div:first-letter {color:red;}</style><div>Axyz</div>");
+
+ Element* div = document().querySelector("div");
+ Node* text = div->firstChild();
+ Position start(text, 0);
+ Position end(text, 4);
+ TextIterator iter(start, end);
+ ForwardsTextBuffer buffer;
+
+ EXPECT_FALSE(iter.atEnd());
+ EXPECT_EQ(1, iter.length());
+ EXPECT_EQ(1, iter.copyTextTo(&buffer, 0)) << "Should emit 'A'.";
+ EXPECT_EQ(text, iter.currentContainer());
+ EXPECT_EQ(Position(text, 0), iter.startPositionInCurrentContainer());
+ EXPECT_EQ(Position(text, 1), iter.endPositionInCurrentContainer());
+
+ iter.advance();
+ EXPECT_FALSE(iter.atEnd());
+ EXPECT_EQ(3, iter.length());
+ EXPECT_EQ(3, iter.copyTextTo(&buffer, 0)) << "Should emit 'xyz'.";
+ EXPECT_EQ(text, iter.currentContainer());
+ EXPECT_EQ(Position(text, 1), iter.startPositionInCurrentContainer());
+ EXPECT_EQ(Position(text, 4), iter.endPositionInCurrentContainer());
+
+ iter.advance();
+ EXPECT_TRUE(iter.atEnd());
+
+ EXPECT_EQ("Axyz", String(buffer.data()));
+}
+
+TEST_F(TextIteratorTest, StartInMultiCharFirstLetterWithCollapsedSpace) {
+ setBodyContent(
+ "<style>div:first-letter {color:red;}</style><div> (A) xyz</div>");
+
+ Element* div = document().querySelector("div");
+ Node* text = div->firstChild();
+ Position start(text, 3);
+ Position end(text, 10);
+ TextIterator iter(start, end);
+ ForwardsTextBuffer buffer;
+
+ EXPECT_FALSE(iter.atEnd());
+ EXPECT_EQ(2, iter.length());
+ EXPECT_EQ(2, iter.copyTextTo(&buffer, 0)) << "Should emit 'A)'.";
+ EXPECT_EQ(text, iter.currentContainer());
+ EXPECT_EQ(Position(text, 3), iter.startPositionInCurrentContainer());
+ EXPECT_EQ(Position(text, 5), iter.endPositionInCurrentContainer());
+
+ iter.advance();
+ EXPECT_FALSE(iter.atEnd());
+ EXPECT_EQ(1, iter.length());
+ EXPECT_EQ(1, iter.copyTextTo(&buffer, 0)) << "Should emit ' '.";
+ EXPECT_EQ(text, iter.currentContainer());
+ EXPECT_EQ(Position(text, 5), iter.startPositionInCurrentContainer());
+ EXPECT_EQ(Position(text, 6), iter.endPositionInCurrentContainer());
+
+ iter.advance();
+ EXPECT_FALSE(iter.atEnd());
+ EXPECT_EQ(3, iter.length());
+ EXPECT_EQ(3, iter.copyTextTo(&buffer, 0)) << "Should emit 'xyz'.";
+ EXPECT_EQ(text, iter.currentContainer());
+ EXPECT_EQ(Position(text, 7), iter.startPositionInCurrentContainer());
+ EXPECT_EQ(Position(text, 10), iter.endPositionInCurrentContainer());
+
+ iter.advance();
+ EXPECT_TRUE(iter.atEnd());
+
+ EXPECT_EQ("A) xyz", String(buffer.data()));
+}
+
+TEST_F(TextIteratorTest, StartAtRemainingText) {
+ setBodyContent("<style>div:first-letter {color:red;}</style><div>Axyz</div>");
+
+ Element* div = document().querySelector("div");
+ Node* text = div->firstChild();
+ Position start(text, 1);
+ Position end(text, 4);
+ TextIterator iter(start, end);
+ ForwardsTextBuffer buffer;
+
+ EXPECT_FALSE(iter.atEnd());
+ EXPECT_EQ(3, iter.length());
+ EXPECT_EQ(3, iter.copyTextTo(&buffer, 0)) << "Should emit 'xyz'.";
+ EXPECT_EQ(text, iter.currentContainer());
+ EXPECT_EQ(Position(text, 1), iter.startPositionInCurrentContainer());
+ EXPECT_EQ(Position(text, 4), iter.endPositionInCurrentContainer());
+
+ iter.advance();
+ EXPECT_TRUE(iter.atEnd());
+
+ EXPECT_EQ("xyz", String(buffer.data()));
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698