Omnibox - Boost Frequency Scores Based on Number of Matching Pages

components/omnibox/browser/omnibox_field_trial.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/omnibox/browser/omnibox_field_trial.h"
 
 #include <cmath>
 #include <string>
 
 #include "base/command_line.h"
@@ skipping 425 matching lines @@
   if (typed_value_str.empty())
     return 20;
   // This is a best-effort conversion; we trust the hand-crafted parameters
   // downloaded from the server to be perfect.  There's no need for handle
   // errors smartly.
   double typed_value;
   base::StringToDouble(typed_value_str, &typed_value);
   return typed_value;
 }
 
+void OmniboxFieldTrial::HQPGetNumMatchesMultipliers(
+    NumMatchesMultipliers* num_matches_multipliers) {
+  std::string str = variations::GetVariationParamValue(
+      kBundledExperimentFieldTrialName, kHQPNumMatchesMultipliersRule);
+  // The parameter is a comma-separated list of (number, value) pairs.
+  // e.g., "1:3,2:2.5,3:2,4:1.5"

[Peter Kasting, 2016/12/01 07:07:53]

Super nitpicky nit:

"pairs, e.g. "..."."

(comma rather than period after "pairs", no period after "e.g.", period at end
of sentence)

[Mark P, 2016/12/04 01:06:41]

Done.

+  // This is a best-effort conversion; we trust the hand-crafted parameters
+  // downloaded from the server to be perfect.  There's no need for handle

[Peter Kasting, 2016/12/01 07:07:53]

Nit: for -> to

[Mark P, 2016/12/04 01:06:41]

Done.

+  // errors smartly.
+  base::StringPairs kv_pairs;
+  if (!base::SplitStringIntoKeyValuePairs(str, ':', ',', &kv_pairs))
+    return;
+  for (base::StringPairs::const_iterator it = kv_pairs.begin();
+       it != kv_pairs.end(); ++it) {

[Peter Kasting, 2016/12/01 07:07:53]

Nit: Range-based for?

[Mark P, 2016/12/04 01:06:41]

Now moot.

+    size_t num;
+    double multiplier;
+    base::StringToSizeT(it->first, &num);
+    base::StringToDouble(it->second, &multiplier);
+    DCHECK(num_matches_multipliers->find(num) ==
+           num_matches_multipliers->end());

[Peter Kasting, 2016/12/01 07:07:53]

Nit: DCHECK(!base::ContainsKey(num_matches_multipliers, num)) ?

[Mark P, 2016/12/04 01:06:41]

Did something similar.

(Between this duplicates-the-immediately-previous-item check and the is_sorted
check, I think everything is covered.)

+    (*num_matches_multipliers)[num] = multiplier;
+  }
+}
+
 size_t OmniboxFieldTrial::HQPNumTitleWordsToAllow() {
   // The value of the rule is a string that encodes an integer (actually
   // size_t) containing the number of words.
   size_t num_title_words;
   if (!base::StringToSizeT(
           variations::GetVariationParamValue(kBundledExperimentFieldTrialName,
                                              kHQPNumTitleWordsRule),
           &num_title_words))
     return 20;
   return num_title_words;
@@ skipping 85 matching lines @@
     "DisableResultsCaching";
 const char
 OmniboxFieldTrial::kMeasureSuggestPollingDelayFromLastKeystrokeRule[] =
     "MeasureSuggestPollingDelayFromLastKeystroke";
 const char OmniboxFieldTrial::kSuggestPollingDelayMsRule[] =
     "SuggestPollingDelayMs";
 const char OmniboxFieldTrial::kHQPFixFewVisitsBugRule[] = "HQPFixFewVisitsBug";
 const char OmniboxFieldTrial::kHQPFreqencyUsesSumRule[] = "HQPFreqencyUsesSum";
 const char OmniboxFieldTrial::kHQPMaxVisitsToScoreRule[] =
     "HQPMaxVisitsToScoreRule";
+const char OmniboxFieldTrial::kHQPNumMatchesMultipliersRule[] =
+    "HQPNumMatchesMultipliers";
 const char OmniboxFieldTrial::kHQPNumTitleWordsRule[] = "HQPNumTitleWords";
 const char OmniboxFieldTrial::kHQPAlsoDoHUPLikeScoringRule[] =
     "HQPAlsoDoHUPLikeScoring";
 const char OmniboxFieldTrial::kHUPSearchDatabaseRule[] =
     "HUPSearchDatabase";
 const char OmniboxFieldTrial::kKeywordRequiresRegistryRule[] =
     "KeywordRequiresRegistry";
 const char OmniboxFieldTrial::kKeywordRequiresPrefixMatchRule[] =
     "KeywordRequiresPrefixMatch";
 const char OmniboxFieldTrial::kKeywordScoreForSufficientlyCompleteMatchRule[] =
@@ skipping 85 matching lines @@
   if (it != params.end())
     return it->second;
   // Fall back to the global instant extended context.
   it = params.find(rule + ":" + page_classification_str + ":*");
   if (it != params.end())
     return it->second;
   // Look up rule in the global context.
   it = params.find(rule + ":*:*");
   return (it != params.end()) ? it->second : std::string();
 }