Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2541123006: Fuchsia: Adds a script to download the prebuilt SDK (Closed)

Created:
4 years ago by zra
Modified:
4 years ago
Reviewers:
Petr Hosek, rmacnak, siva
CC:
reviews_dartlang.org, phosek
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fuchsia: Adds a script to download the prebuild SDK The Fuchsia world doesn't run gclient runhooks or use depot_tools so the advice is to check in a custom script to pull the prebuilt SDK from google storage. R=asiva@google.com, phosek@chromium.org, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/63cb4565d7ccd72b0746cc482473781ebd5c0960

Patch Set 1 #

Patch Set 2 : Fix python script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/tools/create_archive.py View 1 1 chunk +1 line, -0 lines 0 comments Download
A tools/download_prebuilt_sdk.py View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
zra
4 years ago (2016-12-02 19:34:36 UTC) #2
zra
4 years ago (2016-12-02 19:37:38 UTC) #4
Petr Hosek
lgtm
4 years ago (2016-12-02 19:42:03 UTC) #6
siva
lgtm
4 years ago (2016-12-02 21:00:49 UTC) #7
rmacnak
lgtm
4 years ago (2016-12-02 21:07:10 UTC) #8
zra
4 years ago (2016-12-02 21:18:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
63cb4565d7ccd72b0746cc482473781ebd5c0960 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698