Resurrect the cloud printer driver.

Resurrect the cloud printer driver.

This CL relands a working version of the printer driver, stripped of all
32bit pre Win 7 related parts.

Thios CL also fixed the installation problem for Win 10.

BUG=629512
TEST=unit_tests(minimal),manual
TBR=thestig@chromium.org

Committed: https://crrev.com/02d5cc9941cf621f195871e960a82928a19a3076
Cr-Commit-Position: refs/heads/master@{#436344}

[elawrence, 2016-12-01 16:42:11]

https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/win/install/setup.cc (right):

https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
cloud_print/virtual_driver/win/install/setup.cc:37: const wchar_t kGcpUrl[] =
L"http://www.google.com/cloudprint";
Can you please use https://www.google.com/cloudprint instead? We shouldn't have
HTTP URLs in our products when HTTPS is available.

https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/win/install/virtual_driver_setup_resources.grd
(right):

https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
cloud_print/virtual_driver/win/install/virtual_driver_setup_resources.grd:134:
<ph name="xps_url">&lt;a
href=&quot;http://www.microsoft.com/download/details.aspx?id=11816&quot;&gt;<ex>&lt;a
href=&quot;http://www.microsoft.com/download/details.aspx?id=11816&quot;&gt;</ex></ph>XPS
driver<ph name="xps_url_end">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph> is not
installed.
Can we use HTTPS for these URLs here? (Although it may not matter as the XPS
driver is probably built in on Win7+?)

https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/win/port_monitor/port_monitor.cc (right):

https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
cloud_print/virtual_driver/win/port_monitor/port_monitor.cc:44:
"http://google.com/cloudprint/learn/chrome.html";
Can we please use a HTTPS URL here.
https://www.google.com/cloudprint/learn/chrome.html

https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
cloud_print/virtual_driver/win/port_monitor/port_monitor.cc:291:
base::LaunchProcess(command_line, options);
FWIW, this could fail if Internet Explorer is turned off on the system. I assume
there's some reason we're not just ShellExecuting the target hyperlink and
letting the user's default browser take it?

[pastarmovj, 2016-12-01 16:53:26]

On 2016/12/01 16:42:11, elawrence wrote:
>
https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
> File cloud_print/virtual_driver/win/install/setup.cc (right):
> 
>
https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
> cloud_print/virtual_driver/win/install/setup.cc:37: const wchar_t kGcpUrl[] =
> L"http://www.google.com/cloudprint";
> Can you please use https://www.google.com/cloudprint instead? We shouldn't
have
> HTTP URLs in our products when HTTPS is available.
> 
>
https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
> File cloud_print/virtual_driver/win/install/virtual_driver_setup_resources.grd
> (right):
> 
>
https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
> cloud_print/virtual_driver/win/install/virtual_driver_setup_resources.grd:134:
> <ph name="xps_url">&lt;a
>
href=&quot;http://www.microsoft.com/download/details.aspx?id=11816&quot;&gt;<ex>&lt;a
>
href=&quot;http://www.microsoft.com/download/details.aspx?id=11816&quot;&gt;</ex></ph>XPS
> driver<ph name="xps_url_end">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph> is not
> installed.
> Can we use HTTPS for these URLs here? (Although it may not matter as the XPS
> driver is probably built in on Win7+?)
> 
>
https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
> File cloud_print/virtual_driver/win/port_monitor/port_monitor.cc (right):
> 
>
https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
> cloud_print/virtual_driver/win/port_monitor/port_monitor.cc:44:
> "http://google.com/cloudprint/learn/chrome.html";
> Can we please use a HTTPS URL here.
> https://www.google.com/cloudprint/learn/chrome.html
> 
>
https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
> cloud_print/virtual_driver/win/port_monitor/port_monitor.cc:291:
> base::LaunchProcess(command_line, options);
> FWIW, this could fail if Internet Explorer is turned off on the system. I
assume
> there's some reason we're not just ShellExecuting the target hyperlink and
> letting the user's default browser take it?

Thanks for the super fast review! I am planning to make the review process
easier by actually uploading the raw revert first and my changes on top of it.
So you might want to wait until this happens in approx 1h.

Cheers,
Julian

[pastarmovj, 2016-12-01 17:57:41]

I am going to delete the patch set that contained the initial comments because
it goes against the layout I am trying to achieve for more easier reviews.
However the fixes themselves are easily visible in the new CL history as well.

https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/win/install/setup.cc (right):

https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
cloud_print/virtual_driver/win/install/setup.cc:37: const wchar_t kGcpUrl[] =
L"http://www.google.com/cloudprint";
On 2016/12/01 16:42:11, elawrence wrote:
> Can you please use https://www.google.com/cloudprint instead? We shouldn't
have
> HTTP URLs in our products when HTTPS is available.

Done.

https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/win/install/virtual_driver_setup_resources.grd
(right):

https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
cloud_print/virtual_driver/win/install/virtual_driver_setup_resources.grd:134:
<ph name="xps_url">&lt;a
href=&quot;http://www.microsoft.com/download/details.aspx?id=11816&quot;&gt;<ex>&lt;a
href=&quot;http://www.microsoft.com/download/details.aspx?id=11816&quot;&gt;</ex></ph>XPS
driver<ph name="xps_url_end">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph> is not
installed.
On 2016/12/01 16:42:11, elawrence wrote:
> Can we use HTTPS for these URLs here? (Although it may not matter as the XPS
> driver is probably built in on Win7+?)

Done.

https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
File cloud_print/virtual_driver/win/port_monitor/port_monitor.cc (right):

https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
cloud_print/virtual_driver/win/port_monitor/port_monitor.cc:44:
"http://google.com/cloudprint/learn/chrome.html";
On 2016/12/01 16:42:11, elawrence wrote:
> Can we please use a HTTPS URL here.
> https://www.google.com/cloudprint/learn/chrome.html

Done.

https://codereview.chromium.org/2541123003/diff/1/cloud_print/virtual_driver/...
cloud_print/virtual_driver/win/port_monitor/port_monitor.cc:291:
base::LaunchProcess(command_line, options);
On 2016/12/01 16:42:11, elawrence wrote:
> FWIW, this could fail if Internet Explorer is turned off on the system. I
assume
> there's some reason we're not just ShellExecuting the target hyperlink and
> letting the user's default browser take it?

I haven't touched this but I will make a note here to reconsider this choice in
the future.

[pastarmovj, 2016-12-01 18:00:46]

Patchset #1 (id:1) has been deleted

[Vitaly Buka (NO REVIEWS), 2016-12-01 21:58:12]

vitalybuka@chromium.org changed reviewers:
+ vitalybuka@chromium.org

[Vitaly Buka (NO REVIEWS), 2016-12-01 21:58:12]

lgtm

[Vitaly Buka (NO REVIEWS), 2016-12-01 21:59:25]

On 2016/12/01 21:58:12, Vitaly Buka wrote:
> lgtm

Sometimes format looks weird but different from the patch set 1.
Is this clang-formated?

[Vitaly Buka (NO REVIEWS), 2016-12-01 23:39:34]

https://codereview.chromium.org/2541123003/diff/60001/cloud_print/OWNERS
File cloud_print/OWNERS (right):

https://codereview.chromium.org/2541123003/diff/60001/cloud_print/OWNERS#newc...
cloud_print/OWNERS:2: gene@chromium.org
All 3 do no work chromium or cloud print any more.

[pastarmovj, 2016-12-02 19:19:20]

Thanks Vitaly.

I will TBR thestig for the collateral (DEPS and grit resource_ids).

https://codereview.chromium.org/2541123003/diff/60001/cloud_print/OWNERS
File cloud_print/OWNERS (right):

https://codereview.chromium.org/2541123003/diff/60001/cloud_print/OWNERS#newc...
cloud_print/OWNERS:2: gene@chromium.org
On 2016/12/01 23:39:34, Vitaly Buka wrote:
> All 3 do no work chromium or cloud print any more.

I put myself and you (for bus-factor reduction) as temp owners until the proper
owner is found and the destiny of the code is decided. I added extra comment not
to ask you for reviews though unless otherwise impossible.

[pastarmovj, 2016-12-02 19:19:45]

Description was changed from

==========
Resurrect the cloud printer driver.

This CL relands a working version of the printer driver, stripped of all
32bit pre Win 7 related parts.

Thios CL also fixed the installation problem for Win 10.

BUG=629512
TEST=unit_tests(minimal),manual
==========

to

==========
Resurrect the cloud printer driver.

This CL relands a working version of the printer driver, stripped of all
32bit pre Win 7 related parts.

Thios CL also fixed the installation problem for Win 10.

BUG=629512
TEST=unit_tests(minimal),manual
TBR=thestig@chromium.org
==========

[Vitaly Buka (NO REVIEWS), 2016-12-02 19:25:22]

> I put myself and you (for bus-factor reduction) as temp owners until the
proper
> owner is found and the destiny of the code is decided. I added extra comment
not
> to ask you for reviews though unless otherwise impossible.

LGTM

[pastarmovj, 2016-12-05 14:56:26]

The CQ bit was checked by pastarmovj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 14:56:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 16:09:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 16:09:12]

Dry run: This issue passed the CQ dry run.

[pastarmovj, 2016-12-05 17:33:40]

The CQ bit was checked by pastarmovj@chromium.org

[pastarmovj, 2016-12-05 17:33:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
vitalybuka@chromium.org
Link to the patchset: https://codereview.chromium.org/2541123003/#ps100001
(title: "Remove cross-compiling option for the portmon dll.")

[commit-bot: I haz the power, 2016-12-05 17:34:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 17:55:30]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1480959220397390,
"parent_rev": "b9141f8fcd8581a9553a3d6931f1d77177e979d9", "commit_rev":
"7eb9cf5a8e07e73602680522eb7421114ed502e1"}

[commit-bot: I haz the power, 2016-12-05 17:56:01]

Description was changed from

==========
Resurrect the cloud printer driver.

This CL relands a working version of the printer driver, stripped of all
32bit pre Win 7 related parts.

Thios CL also fixed the installation problem for Win 10.

BUG=629512
TEST=unit_tests(minimal),manual
TBR=thestig@chromium.org
==========

to

==========
Resurrect the cloud printer driver.

This CL relands a working version of the printer driver, stripped of all
32bit pre Win 7 related parts.

Thios CL also fixed the installation problem for Win 10.

BUG=629512
TEST=unit_tests(minimal),manual
TBR=thestig@chromium.org
==========

[commit-bot: I haz the power, 2016-12-05 17:56:02]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-12-05 17:58:15]

Description was changed from

==========
Resurrect the cloud printer driver.

This CL relands a working version of the printer driver, stripped of all
32bit pre Win 7 related parts.

Thios CL also fixed the installation problem for Win 10.

BUG=629512
TEST=unit_tests(minimal),manual
TBR=thestig@chromium.org
==========

to

==========
Resurrect the cloud printer driver.

This CL relands a working version of the printer driver, stripped of all
32bit pre Win 7 related parts.

Thios CL also fixed the installation problem for Win 10.

BUG=629512
TEST=unit_tests(minimal),manual
TBR=thestig@chromium.org

Committed: https://crrev.com/02d5cc9941cf621f195871e960a82928a19a3076
Cr-Commit-Position: refs/heads/master@{#436344}
==========

[commit-bot: I haz the power, 2016-12-05 17:58:16]

Patchset 5 (id:??) landed as
https://crrev.com/02d5cc9941cf621f195871e960a82928a19a3076
Cr-Commit-Position: refs/heads/master@{#436344}