Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2541113003: MD Settings: add an external icon to "Manage sync" row on /syncSetup (Closed)

Created:
4 years ago by Dan Beam
Modified:
4 years ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: add an external icon to "Manage sync" row on /syncSetup R=tommycli@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c0c6279d3e68403d3c6eeb976362b92de469f53b Cr-Commit-Position: refs/heads/master@{#435678}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/resources/settings/people_page/sync_page.html View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Dan Beam
4 years ago (2016-12-01 18:34:17 UTC) #2
tommycli
lgtm
4 years ago (2016-12-01 18:35:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541113003/1
4 years ago (2016-12-01 18:42:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 19:39:35 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-01 19:41:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0c6279d3e68403d3c6eeb976362b92de469f53b
Cr-Commit-Position: refs/heads/master@{#435678}

Powered by Google App Engine
This is Rietveld 408576698