Instrument SSL sockets using MemoryDumpProvider

net/http/http_network_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_network_session.h"
 
 #include <utility>
 
 #include "base/atomic_sequence_num.h"
 #include "base/compiler_specific.h"
 #include "base/debug/stack_trace.h"
 #include "base/logging.h"
 #include "base/memory/memory_coordinator_client_registry.h"
 #include "base/memory/ptr_util.h"
 #include "base/profiler/scoped_tracker.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
+#include "base/strings/stringprintf.h"
+#include "base/trace_event/memory_allocator_dump.h"
+#include "base/trace_event/process_memory_dump.h"
 #include "base/values.h"
 #include "net/base/network_throttle_manager_impl.h"
 #include "net/http/http_auth_handler_factory.h"
 #include "net/http/http_response_body_drainer.h"
 #include "net/http/http_stream_factory_impl.h"
 #include "net/http/url_security_manager.h"
 #include "net/proxy/proxy_service.h"
 #include "net/quic/chromium/quic_stream_factory.h"
 #include "net/quic/core/crypto/quic_random.h"
 #include "net/quic/core/quic_crypto_client_stream_factory.h"
@@ skipping 342 matching lines @@
   ssl_config_service_->GetSSLConfig(server_config);
   GetAlpnProtos(&server_config->alpn_protos);
   *proxy_config = *server_config;
   if (request.privacy_mode == PRIVACY_MODE_ENABLED) {
     server_config->channel_id_enabled = false;
   } else if (params_.enable_token_binding && params_.channel_id_service) {
     server_config->token_binding_params.push_back(TB_PARAM_ECDSAP256);
   }
 }
 
+void HttpNetworkSession::DumpMemoryStats(
+    base::trace_event::ProcessMemoryDump* pmd,
+    const std::string& parent_absolute_name) const {
+  std::string name = base::StringPrintf("net/http_network_session_%p", this);
+  base::trace_event::MemoryAllocatorDump* http_network_session_dump =
+      pmd->GetAllocatorDump(name);
+  // If memory dump already exists, it means that this is not the first
+  // DumpMemoryStats() invocation on this object and it is reached by another
+  // "parent." If that's the case, add an ownership edge and return early.
+  // This is needed because URLRequestContexts can share an HttpNetworkSession.
+  if (http_network_session_dump != nullptr) {
+    pmd->AddOwnershipEdge(pmd->GetAllocatorDump(parent_absolute_name)->guid(),

[Primiano Tucci (use gerrit), 2016/12/06 17:06:28]

Hmm I think this is not going to make anything useful (if not hit a DCHECK).
What is the intented result of this?

The part where you check if network_session_X exists and early out is okay. But
creating two edges between the same nodes doesn't make lot of sense.

[xunjieli, 2016/12/06 18:36:08]

No, it won't ever create two edges between the same nodes.

Say we have context1 and context2, which share a http_network_session.
context1->OnMemoryDump() calls http_network_session::DumpMemoryStats() and adds
an edge between context1 and http_network_session.
context2->OnMemoryDump() will add an edge between context2 and
http_network_session.

[Primiano Tucci (use gerrit), 2016/12/06 20:15:41]

We had an offline chat on this. I dumped my brain on
https://docs.google.com/document/d/1-dmr_dVgO090Y5_3K9itjsE0MsBTmbqwovu6lup1i...

The rest of this CL makes sense to me, and I think we are aligned on two
possible options here.
My suggestion is to go ahead and land this regardless of this conversation (%
net owners being okay with the rest of the code) in order to avoid a cross
timezone round-trip-time.
Even in the worst case this is the kind of thing that can be fixed quite easily
in a follow-up.
So speculatively LGTM from the memory-reporting viewpoint.

Thanks a lot for working on this, It's quite conceptually challenging (also fun)
:)

[xunjieli, 2016/12/06 21:22:11]

Thanks for the follow-up! I tried your suggestion (Option #2), but I don't think
the UI gives what we want. I will keep this as it is and continue this
discussion via email.

+                          http_network_session_dump->guid());
+
+    return;
+  }
+  http_network_session_dump = pmd->CreateAllocatorDump(name);
+  normal_socket_pool_manager_->DumpMemoryStats(
+      pmd, http_network_session_dump->absolute_name());
+  pmd->AddOwnershipEdge(pmd->GetAllocatorDump(parent_absolute_name)->guid(),
+                        http_network_session_dump->guid());
+}
+
 ClientSocketPoolManager* HttpNetworkSession::GetSocketPoolManager(
     SocketPoolType pool_type) {
   switch (pool_type) {
     case NORMAL_SOCKET_POOL:
       return normal_socket_pool_manager_.get();
     case WEBSOCKET_SOCKET_POOL:
       return websocket_socket_pool_manager_.get();
     default:
       NOTREACHED();
       break;
@@ skipping 25 matching lines @@
       break;
     case base::MemoryState::SUSPENDED:
     // Note: Not supported at present. Fall through.
     case base::MemoryState::UNKNOWN:
       NOTREACHED();
       break;
   }
 }
 
 }  // namespace net