[ios] Updates ios DEPS files to mirror desktop DEPS files.

[ios] Updates ios DEPS files to mirror desktop DEPS files.

Updates ios DEPS files to mirror the desktop DEPS files.  For example, the rules
in ios/DEPS roughly resemble the rules in DEPS, and the rules in ios/chrome/DEPS
roughly resemble the rules in chrome/DEPS.

Also adds some new rules to accomodate iOS code that will be landing in the near
future.

BUG=665969
Committed: https://crrev.com/098884e1c4dbe4a833eaa7bbf55bebbba2186220
Cr-Commit-Position: refs/heads/master@{#436313}

[rohitrao (ping after 24h), 2016-11-30 16:52:53]

rohitrao@chromium.org changed reviewers:
+ sdefresne@chromium.org

[rohitrao (ping after 24h), 2016-11-30 16:52:53]

You need LGTM from owners of depends-on paths in DEPS that were modified in this
CL:
    '+breakpad/src/client/ios',
    '+components/bookmarks/browser',
    '+components/bookmarks/test',
    '+components/browser_sync',
    '+components/browsing_data/core',
    '+components/component_updater',
    '+components/content_settings',
    '+components/crash/core/common',
    '+components/error_page/common',
    '+components/favicon/core',
    '+components/favicon/ios',
    '+components/favicon_base',
    '+components/handoff',
    '+components/history/core/browser',
    '+components/metrics',
    '+components/prefs',
    '+components/query_parser',
    '+components/reading_list/core',
    '+components/signin/core/browser',
    '+components/ssl_errors',
    '+components/strings',
    '+components/suggestions',
    '+components/toolbar',
    '+components/url_formatter',
    '+components/web_resource',
    '+crypto',
    '+ios/chrome/common',
    '+ios/chrome/test',
    '+ios/testing',
    '+libxml',
    '+mojo/edk/embedder/embedder.h',
    '+net',
    '+skia/ext/skia_utils_ios.h',
    '+sql',
    '+third_party/skia/include/core/SkBitmap.h',
    '+third_party/skia/include/core/SkColor.h',
    '+third_party/skia/include/core/SkGraphics.h',
    '+ui/base',
    '+ui/gfx',

[sdefresne, 2016-11-30 16:58:54]

lgtm

https://codereview.chromium.org/2541083002/diff/1/ios/DEPS
File ios/DEPS (right):

https://codereview.chromium.org/2541083002/diff/1/ios/DEPS#newcode9
ios/DEPS:9: "-ios/third_party/ochamcrest",
Can you add "-ios/third_party/EarlGrey" here (for the same reason).

https://codereview.chromium.org/2541083002/diff/1/ios/chrome/browser/DEPS
File ios/chrome/browser/DEPS (right):

https://codereview.chromium.org/2541083002/diff/1/ios/chrome/browser/DEPS#new...
ios/chrome/browser/DEPS:2: "+ios/chrome/common",
I think this is already allowed by src/ios/chrome/DEPS (in your CL).

https://codereview.chromium.org/2541083002/diff/1/ios/chrome/browser/DEPS#new...
ios/chrome/browser/DEPS:111: "+ios/testing",
ditto, this is already allowed by ios/chrome/DEPS in the current CL.

[rohitrao (ping after 24h), 2016-11-30 17:12:48]

https://codereview.chromium.org/2541083002/diff/1/ios/DEPS
File ios/DEPS (right):

https://codereview.chromium.org/2541083002/diff/1/ios/DEPS#newcode9
ios/DEPS:9: "-ios/third_party/ochamcrest",
On 2016/11/30 16:58:54, sdefresne wrote:
> Can you add "-ios/third_party/EarlGrey" here (for the same reason).

Done.

https://codereview.chromium.org/2541083002/diff/1/ios/chrome/browser/DEPS
File ios/chrome/browser/DEPS (right):

https://codereview.chromium.org/2541083002/diff/1/ios/chrome/browser/DEPS#new...
ios/chrome/browser/DEPS:2: "+ios/chrome/common",
On 2016/11/30 16:58:54, sdefresne wrote:
> I think this is already allowed by src/ios/chrome/DEPS (in your CL).

Done.

https://codereview.chromium.org/2541083002/diff/1/ios/chrome/browser/DEPS#new...
ios/chrome/browser/DEPS:111: "+ios/testing",
On 2016/11/30 16:58:54, sdefresne wrote:
> ditto, this is already allowed by ios/chrome/DEPS in the current CL.

Done.

[rohitrao (ping after 24h), 2016-11-30 17:24:18]

rohitrao@chromium.org changed reviewers:
+ davidben@chromium.org, mark@chromium.org, reed@chromium.org,
shess@chromium.org, sky@chromium.org

[rohitrao (ping after 24h), 2016-11-30 17:24:19]

OWNERS, please review the following DEPS additions.  All of these are in ios,
either reshuffling existing rules to mirror desktop more closely or adding new
rules for code that will be landing soon.  Thanks!

mark@
'+breakpad/src/client/ios',

davidben@
'+crypto',
'+net',

reed@
'+skia/ext/skia_utils_ios.h',
'+third_party/skia/include/core/SkBitmap.h',
'+third_party/skia/include/core/SkColor.h',
'+third_party/skia/include/core/SkGraphics.h',

sdefresne@
components/

shess@
'+sql',

sky@
'+mojo/edk/embedder/embedder.h',
'+ui/base',
'+ui/gfx',

[sdefresne, 2016-11-30 17:25:48]

components/ lgtm (as those components were created to share the code with iOS)

[davidben, 2016-11-30 17:30:24]

lgtm

https://codereview.chromium.org/2541083002/diff/20001/ios/chrome/DEPS
File ios/chrome/DEPS (right):

https://codereview.chromium.org/2541083002/diff/20001/ios/chrome/DEPS#newcode3
ios/chrome/DEPS:3: "-crypto/third_party",
This directory doesn't exist anymore. (I'll go take it out of chrome/DEPS.)

[Mark Mentovai, 2016-11-30 17:31:33]

LGTM otherwise

[Scott Hess - ex-Googler, 2016-11-30 17:36:48]

lgtm

[sky, 2016-11-30 21:26:49]

LGTM

[rohitrao (ping after 24h), 2016-12-01 13:58:41]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 13:58:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 14:09:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 14:09:54]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2016-12-02 11:53:29]

rohitrao@chromium.org changed reviewers:
+ bsalomon@google.com, reed@google.com
- reed@chromium.org

[rohitrao (ping after 24h), 2016-12-02 11:53:29]

+bsalomon who was asked to do a different review involving ios skia deps

[rohitrao (ping after 24h), 2016-12-05 13:13:13]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 13:13:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 13:22:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 13:22:22]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-12-05 15:57:08]

lgtm

[rohitrao (ping after 24h), 2016-12-05 16:11:25]

The CQ bit was checked by rohitrao@chromium.org

[rohitrao (ping after 24h), 2016-12-05 16:11:25]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
davidben@chromium.org, mark@chromium.org, sdefresne@chromium.org,
shess@chromium.org, bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2541083002/#ps70001
(title: "Remove libxml for now.")

[commit-bot: I haz the power, 2016-12-05 16:11:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 16:25:49]

CQ is committing da patch.

Bot data: {"patchset_id": 70001, "attempt_start_ts": 1480954285271590,
"parent_rev": "192f1c8922cc370258f554c879c9696803444fc2", "commit_rev":
"305362d383c3154888dd22f1f7d5b87489e874f5"}

[commit-bot: I haz the power, 2016-12-05 16:26:17]

Committed patchset #5 (id:70001)

[commit-bot: I haz the power, 2016-12-05 16:28:57]

Description was changed from

==========
[ios] Updates ios DEPS files to mirror desktop DEPS files.

Updates ios DEPS files to mirror the desktop DEPS files.  For example, the rules
in ios/DEPS roughly resemble the rules in DEPS, and the rules in ios/chrome/DEPS
roughly resemble the rules in chrome/DEPS.

Also adds some new rules to accomodate iOS code that will be landing in the near
future.

BUG=665969
==========

to

==========
[ios] Updates ios DEPS files to mirror desktop DEPS files.

Updates ios DEPS files to mirror the desktop DEPS files.  For example, the rules
in ios/DEPS roughly resemble the rules in DEPS, and the rules in ios/chrome/DEPS
roughly resemble the rules in chrome/DEPS.

Also adds some new rules to accomodate iOS code that will be landing in the near
future.

BUG=665969

Committed: https://crrev.com/098884e1c4dbe4a833eaa7bbf55bebbba2186220
Cr-Commit-Position: refs/heads/master@{#436313}
==========

[commit-bot: I haz the power, 2016-12-05 16:28:58]

Patchset 5 (id:??) landed as
https://crrev.com/098884e1c4dbe4a833eaa7bbf55bebbba2186220
Cr-Commit-Position: refs/heads/master@{#436313}