Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Issue 2541073004: ABANDONED CL: Revert of Move EventHandler timers to per-frame task queues. (Closed)

Created:
4 years ago by Łukasz Anforowicz
Modified:
4 years ago
CC:
chromium-reviews, blink-reviews, dtapuska+blinkwatch_chromium.org, Navid Zolghadr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ABANDONED CL: The failing test was instead disabled in https://codereview.chromium.org/2541963003/ ---- Revert of Move EventHandler timers to per-frame task queues. (patchset #3 id:40001 of https://codereview.chromium.org/2514733003/ ) Reason for revert: After this CL http/tests/security/opened-document-security-origin-resets-on-navigation.html layout test times out when run with --site-per-process flag. See also https://crbug.com/670105. Original issue's description: > Move EventHandler timers to per-frame task queues. > > BUG=624694 > > Committed: https://crrev.com/b8252b996657abe9e655c1b78bc15edb03821870 > Cr-Commit-Position: refs/heads/master@{#435352} TBR=haraken@chromium.org,alexclarke@chromium.org,foolip@chromium.org,tdresser@chromium.org,dcheng@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624694

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -51 lines) Patch
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 7 chunks +14 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/input/GestureManager.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/input/GestureManager.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/input/KeyboardEventManager.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/KeyboardEventManager.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/MouseEventManager.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/MouseEventManager.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/ScrollManager.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/ScrollManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/TouchEventManager.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/TouchEventManager.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Łukasz Anforowicz
Created Revert of Move EventHandler timers to per-frame task queues.
4 years ago (2016-11-30 23:49:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541073004/1
4 years ago (2016-11-30 23:49:44 UTC) #4
haraken
LGTM to revert.
4 years ago (2016-11-30 23:50:21 UTC) #5
Łukasz Anforowicz
4 years ago (2016-11-30 23:57:23 UTC) #6
On 2016/11/30 23:50:21, haraken wrote:
> LGTM to revert.

Actually, I've chatted with Daniel and he asked to disable the test instead.  I
am putting together a CL for this at
https://codereview.chromium.org/2541963003/patch/1/10001

Powered by Google App Engine
This is Rietveld 408576698