Revert of Remove about:srcdoc url conversion.

Revert of Remove about:srcdoc url conversion. (patchset #13 id:560001 of https://codereview.chromium.org/2494633004/ )

Reason for revert:
Speculative revert for http://crbug.com/660061#c2

Original issue's description:
> Remove about:srcdoc url conversion.
>
> Before this CL, there was an asymmetry between the renderer and the
> browser. Iframe that has navigated to its srcdoc attribute got the
> about:srcdoc URL in the renderer and the about:blank in the browser.
> The about::srcdoc URLs were converted to about::blank in the RendererFrameHost.
> A boolean |is_srcdoc| was created and transmitted across classes in
> the browser to keep track of the "real" URL, such as it could be
> converted back (browser->renderer).
>
> This led to a lot unnecessary works to keep track of this boolean and
> not to forget to convert the URL back.
>
> This CL removes the conversion and the boolean from the browser.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> BUG=660061
>
> Committed: https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3
> Cr-Commit-Position: refs/heads/master@{#435256}

TBR=jochen@chromium.org,creis@chromium.org,dbeam@chromium.org,nasko@chromium.org,paulmeyer@chromium.org,lfg@chromium.org,arthursonzogni@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=660061
Committed: https://crrev.com/540e74c6588be2edeb6d9f075d534d13f0bb9ac0
Cr-Commit-Position: refs/heads/master@{#435267}

[battre, 2016-11-30 15:37:47]

The CQ bit was checked by battre@chromium.org

[battre, 2016-11-30 15:37:48]

Created Revert of Remove about:srcdoc url conversion.

[commit-bot: I haz the power, 2016-11-30 15:38:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 15:39:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480520267637200, "parent_rev":
"f9b38315c7f047b1135db1d953af28eca929d4ed", "commit_rev":
"cd1f2918e26f657f5b6a8ae54952983ea51cbced"}

[commit-bot: I haz the power, 2016-11-30 15:40:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-30 15:42:26]

Description was changed from

==========
Revert of Remove about:srcdoc url conversion. (patchset #13 id:560001 of
https://codereview.chromium.org/2494633004/ )

Reason for revert:
Speculative revert for http://crbug.com/660061#c2

Original issue's description:
> Remove about:srcdoc url conversion.
> 
> Before this CL, there was an asymmetry between the renderer and the
> browser. Iframe that has navigated to its srcdoc attribute got the
> about:srcdoc URL in the renderer and the about:blank in the browser.
> The about::srcdoc URLs were converted to about::blank in the
RendererFrameHost.
> A boolean |is_srcdoc| was created and transmitted across classes in
> the browser to keep track of the "real" URL, such as it could be
> converted back (browser->renderer).
> 
> This led to a lot unnecessary works to keep track of this boolean and
> not to forget to convert the URL back.
> 
> This CL removes the conversion and the boolean from the browser.
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> BUG=660061
> 
> Committed: https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3
> Cr-Commit-Position: refs/heads/master@{#435256}

TBR=jochen@chromium.org,creis@chromium.org,dbeam@chromium.org,nasko@chromium....
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=660061
==========

to

==========
Revert of Remove about:srcdoc url conversion. (patchset #13 id:560001 of
https://codereview.chromium.org/2494633004/ )

Reason for revert:
Speculative revert for http://crbug.com/660061#c2

Original issue's description:
> Remove about:srcdoc url conversion.
>
> Before this CL, there was an asymmetry between the renderer and the
> browser. Iframe that has navigated to its srcdoc attribute got the
> about:srcdoc URL in the renderer and the about:blank in the browser.
> The about::srcdoc URLs were converted to about::blank in the
RendererFrameHost.
> A boolean |is_srcdoc| was created and transmitted across classes in
> the browser to keep track of the "real" URL, such as it could be
> converted back (browser->renderer).
>
> This led to a lot unnecessary works to keep track of this boolean and
> not to forget to convert the URL back.
>
> This CL removes the conversion and the boolean from the browser.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> BUG=660061
>
> Committed: https://crrev.com/041956a261766b15f09b7b7a37026bda1ef809f3
> Cr-Commit-Position: refs/heads/master@{#435256}

TBR=jochen@chromium.org,creis@chromium.org,dbeam@chromium.org,nasko@chromium....
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=660061

Committed: https://crrev.com/540e74c6588be2edeb6d9f075d534d13f0bb9ac0
Cr-Commit-Position: refs/heads/master@{#435267}
==========

[commit-bot: I haz the power, 2016-11-30 15:42:28]

Patchset 1 (id:??) landed as
https://crrev.com/540e74c6588be2edeb6d9f075d534d13f0bb9ac0
Cr-Commit-Position: refs/heads/master@{#435267}

[chromium-reviews, 2016-11-30 15:50:58]

I confirm the problem with my patch.

On Wed, Nov 30, 2016 at 4:42 PM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Patchset 1 (id:??) landed as
> https://crrev.com/540e74c6588be2edeb6d9f075d534d13f0bb9ac0
> Cr-Commit-Position: refs/heads/master@{#435267}
>
> https://codereview.chromium.org/2541063002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.