Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2540963002: Fix use of base/numerics in IntToString (Closed)

Created:
4 years ago by jschuh
Modified:
4 years ago
Reviewers:
dcheng
CC:
chromium-reviews, jshin+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix use of base/numerics in IntToString TBR=dcheng@chromium.org R=dcheng@chromium.org BUG=668713 Committed: https://crrev.com/565f9c7c77356de8a134b5a519c6626f7a16d6a6 Cr-Commit-Position: refs/heads/master@{#435175}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M base/strings/string_number_conversions.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540963002/1
4 years ago (2016-11-30 05:49:19 UTC) #2
dcheng
So wow. Much C++. Such elegant. LGTM (Semi-serious question: can/should we just write UINT instead ...
4 years ago (2016-11-30 05:58:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 08:38:58 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/565f9c7c77356de8a134b5a519c6626f7a16d6a6 Cr-Commit-Position: refs/heads/master@{#435175}
4 years ago (2016-11-30 08:43:33 UTC) #7
jschuh
4 years ago (2016-12-02 14:31:39 UTC) #8
Message was sent while issue was closed.
On 2016/11/30 05:58:11, dcheng wrote:
> So wow. Much C++. Such elegant. LGTM
> 
> (Semi-serious question: can/should we just write UINT instead of writing this
> abomination)

Holy crap I just learned that std::make_unsigned is a thing! I'm gonna try a CL
with that thing instead!

Powered by Google App Engine
This is Rietveld 408576698