Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2540863005: Add DEPS and minimal build configuration for Capstone disassembler. (Closed)

Created:
4 years ago by Sigurður Ásgeirsson
Modified:
4 years ago
CC:
syzygy-changes_googlegroups.com
Target Ref:
refs/heads/master
Project:
syzygy
Visibility:
Public.

Description

Add DEPS and minimal build configuration for Capstone disassembler. BUG= Committed: https://github.com/google/syzygy/commit/f697cb58210fa96dcbf77beade406cab3d4e7214

Patch Set 1 #

Total comments: 1

Patch Set 2 : Now even links. #

Patch Set 3 : Merge ToT, address Seb's comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/capstone/capstone.gyp View 1 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Sigurður Ásgeirsson
Don't take much to get it to compile.
4 years ago (2016-11-30 18:06:16 UTC) #4
Sébastien Marchand
LGTM, adding it is probably fine but I thought that most of our code was ...
4 years ago (2016-11-30 18:08:49 UTC) #5
Sigurður Ásgeirsson
The idea here is to supplement Distorm with Capstone, not to replace it outright - ...
4 years ago (2016-11-30 18:59:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540863005/40001
4 years ago (2016-11-30 19:04:40 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-30 19:45:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/google/syzygy/commit/f697cb58210fa96dcbf77beade406cab3d4e7214

Powered by Google App Engine
This is Rietveld 408576698