Remove the now unnecessary flag from test files

Remove the now unnecessary flag from test files

R=asiva@google.com, eernst@google.com

Committed: https://github.com/dart-lang/sdk/commit/f45f21ae425d1a5d43a9fe6a4bfc0ae80dcee91b

[Brian Wilkerson, 2016-11-29 21:44:45]

brianwilkerson@google.com changed reviewers:
+ eernst@google.com

[eernst, 2016-11-30 08:54:27]

LGTM, noting the following minor concern:

When I changed dart2js to not need `DartOptions` in the test files, there was
one tool still needing them (the analyzer), so I couldn't remove these
directives. But now where the analyzer doesn't need these `DartOptions` either,
they can be removed.

However, neither dart2js nor the analyzer depends on `VMOptions` (as far as I
know, certainly dart2js doesn't need them), so removing `VMOptions` is not
motivated by the change to the analyzer, and it might affect the VM (except that
the VM should not need these `VMOptions` either, because of commit
b48435197abe5b29a6244f52c957e758f0e6c3b7).

So I think the entire CL is safe, but I think it would be good if you could send
email to the VM team saying "We removed these `VMOptions` directives from [those
test files], because we don't think you need them any more". Just so nobody gets
confused about what's going on. ;)

[Brian Wilkerson, 2016-11-30 15:46:45]

brianwilkerson@google.com changed reviewers:
+ asiva@google.com

[Brian Wilkerson, 2016-11-30 15:46:45]

I'd rather have someone from the VM team tell me before I commit the change if I
should add those back in.

[eernst, 2016-11-30 16:29:17]

Very good, in that case I'd suggest that you remove the `DartOptions` and keep
the `VMOptions`, as originally proposed.

[eernst, 2016-11-30 16:56:19]

On 2016/11/30 16:29:17, eernst wrote:
> Very good, in that case I'd suggest that you remove the `DartOptions` and keep
> the `VMOptions`, as originally proposed.

Oops, you said "add them back in", but it was you who removed both
`DartOptions` and `VMOptions`, so you should just omit the removal
of `VMOptions`. Right?

[Brian Wilkerson, 2016-11-30 17:10:01]

I added Siva as a reviewer and am hoping to get a review today.

[eernst, 2016-11-30 17:12:41]

On 2016/11/30 17:10:01, Brian Wilkerson wrote:
> I added Siva as a reviewer and am hoping to get a review today.

OK, it's actually not so urgent: No users of the 1.21 release will be hurt by
having those `..Options` in these test files, they are just redundant because
the feature is enabled unconditionally. So we can cherry-pick them for the
aesthetics, or just let it be part of 1.22. ;)

[siva, 2016-12-02 00:22:19]

lgtm

[Brian Wilkerson, 2016-12-02 15:43:06]

Description was changed from

==========
Remove the now unnecessary flag from test files
==========

to

==========
Remove the now unnecessary flag from test files

R=asiva@google.com, eernst@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f45f21ae425d1a5d43a9fe6a4bfc0ae80dcee91b
==========

[Brian Wilkerson, 2016-12-02 15:43:07]

Committed patchset #1 (id:1) manually as
f45f21ae425d1a5d43a9fe6a4bfc0ae80dcee91b (presubmit successful).