Deflake tests in http/tests/appcache/ when run in random order

Deflake tests in http/tests/appcache/ when run in random order

The tests use sync XHR to poke the server to tweak the AppCache manifest
state. Since the manifest is PHP server is re-used across tests the
initial state could be unexpected. The tests handled this as necessary,
but meant that a variable number of sync XHRs would be issued. Since
sync XHRs log a deprecation warning the output was flaky. Fix this
by switching server control to async XHR.

Additionally, obsolete-error-events.html would time out if no update
was needed, so handle the 'noupdate' event too.

BUG=663860
R=jeffcarp@chromium.org

Committed: https://crrev.com/1b6aabf1422f519dfe93fde0ba65b04c3a7a60a8
Cr-Commit-Position: refs/heads/master@{#435450}

[jsbell, 2016-11-29 21:38:12]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[jsbell, 2016-11-29 21:38:29]

Description was changed from

==========
Deflake tests in http/tests/appcache/ when run in random order

The tests use sync XHR to poke the server to tweak the AppCache manifest
state. Since the manifest is PHP server is re-used across tests the
initial state could be unexpected. The tests handled this as necessary,
but meant that a variable number of sync XHRs would be issued. Since
sync XHRs log a deprecation warning the output was flaky.

Additionally, obsolete-error-events.html would time out if no update
was needed, so handle the 'noupdate' event too.

BUG=663860
R=jeffcarp@chromium.org
==========

to

==========
Deflake tests in http/tests/appcache/ when run in random order

The tests use sync XHR to poke the server to tweak the AppCache manifest
state. Since the manifest is PHP server is re-used across tests the
initial state could be unexpected. The tests handled this as necessary,
but meant that a variable number of sync XHRs would be issued. Since
sync XHRs log a deprecation warning the output was flaky. Fix this
by switching server control to async XHR.

Additionally, obsolete-error-events.html would time out if no update
was needed, so handle the 'noupdate' event too.

BUG=663860
R=jeffcarp@chromium.org
==========

[jsbell, 2016-11-29 21:38:40]

jeffcarp@ - please take a look?

[commit-bot: I haz the power, 2016-11-29 21:38:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 23:40:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 23:40:40]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)

[jeffcarp, 2016-11-30 20:21:10]

On 2016/11/29 at 21:38:40, jsbell wrote:
> jeffcarp@ - please take a look?

Looks great! Can you also remove the tests from RandomOrderExpectations?
Otherwise lgtm.

[jsbell, 2016-11-30 21:33:17]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2016-11-30 21:33:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
jeffcarp@chromium.org
Link to the patchset: https://codereview.chromium.org/2540833002/#ps20001
(title: "remove tests from RandomOrderExpectations")

[jsbell, 2016-11-30 21:33:17]

On 2016/11/30 20:21:10, jeffcarp wrote:
> On 2016/11/29 at 21:38:40, jsbell wrote:
> > jeffcarp@ - please take a look?
> 
> Looks great! Can you also remove the tests from RandomOrderExpectations?
> Otherwise lgtm.

Thanks for the reminder - done!

[commit-bot: I haz the power, 2016-11-30 21:33:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 21:36:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 21:36:51]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jsbell, 2016-11-30 21:40:18]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2016-11-30 21:40:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
jeffcarp@chromium.org
Link to the patchset: https://codereview.chromium.org/2540833002/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2016-11-30 21:40:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 22:31:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480542018739080,
"parent_rev": "bb2ffdf14e80aa9adbe98d2ae6805be10ee42066", "commit_rev":
"e58954c123ec806c2b4e62cf718c8757883aeabe"}

[commit-bot: I haz the power, 2016-11-30 22:31:44]

Description was changed from

==========
Deflake tests in http/tests/appcache/ when run in random order

The tests use sync XHR to poke the server to tweak the AppCache manifest
state. Since the manifest is PHP server is re-used across tests the
initial state could be unexpected. The tests handled this as necessary,
but meant that a variable number of sync XHRs would be issued. Since
sync XHRs log a deprecation warning the output was flaky. Fix this
by switching server control to async XHR.

Additionally, obsolete-error-events.html would time out if no update
was needed, so handle the 'noupdate' event too.

BUG=663860
R=jeffcarp@chromium.org
==========

to

==========
Deflake tests in http/tests/appcache/ when run in random order

The tests use sync XHR to poke the server to tweak the AppCache manifest
state. Since the manifest is PHP server is re-used across tests the
initial state could be unexpected. The tests handled this as necessary,
but meant that a variable number of sync XHRs would be issued. Since
sync XHRs log a deprecation warning the output was flaky. Fix this
by switching server control to async XHR.

Additionally, obsolete-error-events.html would time out if no update
was needed, so handle the 'noupdate' event too.

BUG=663860
R=jeffcarp@chromium.org
==========

[commit-bot: I haz the power, 2016-11-30 22:31:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-30 22:34:50]

Description was changed from

==========
Deflake tests in http/tests/appcache/ when run in random order

The tests use sync XHR to poke the server to tweak the AppCache manifest
state. Since the manifest is PHP server is re-used across tests the
initial state could be unexpected. The tests handled this as necessary,
but meant that a variable number of sync XHRs would be issued. Since
sync XHRs log a deprecation warning the output was flaky. Fix this
by switching server control to async XHR.

Additionally, obsolete-error-events.html would time out if no update
was needed, so handle the 'noupdate' event too.

BUG=663860
R=jeffcarp@chromium.org
==========

to

==========
Deflake tests in http/tests/appcache/ when run in random order

The tests use sync XHR to poke the server to tweak the AppCache manifest
state. Since the manifest is PHP server is re-used across tests the
initial state could be unexpected. The tests handled this as necessary,
but meant that a variable number of sync XHRs would be issued. Since
sync XHRs log a deprecation warning the output was flaky. Fix this
by switching server control to async XHR.

Additionally, obsolete-error-events.html would time out if no update
was needed, so handle the 'noupdate' event too.

BUG=663860
R=jeffcarp@chromium.org

Committed: https://crrev.com/1b6aabf1422f519dfe93fde0ba65b04c3a7a60a8
Cr-Commit-Position: refs/heads/master@{#435450}
==========

[commit-bot: I haz the power, 2016-11-30 22:34:51]

Patchset 3 (id:??) landed as
https://crrev.com/1b6aabf1422f519dfe93fde0ba65b04c3a7a60a8
Cr-Commit-Position: refs/heads/master@{#435450}