Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2540803004: X87: [stubs] Port builtin for Array.push fast-case from Crankshaft to TF. (Closed)

Created:
4 years ago by zhengxing.li
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [stubs] Port builtin for Array.push fast-case from Crankshaft to TF. port df2578d2ec630ccd08619e1f733da3f61e7ee380 (r41368) original commit message: Improves performance in simple, single element case by 5% and in multiple elements cases by 2%. BUG= Committed: https://crrev.com/77a9da6b2061fe76134d89a942d78721fe3e42f0 Cr-Commit-Position: refs/heads/master@{#41377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
zhengxing.li
PTAL, thanks!
4 years ago (2016-11-30 02:01:30 UTC) #2
chunyang.dai
LGTM but we need Danno's review. thanks
4 years ago (2016-11-30 06:26:37 UTC) #3
zhengxing.li
PTAL, thanks!
4 years ago (2016-11-30 06:42:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540803004/1
4 years ago (2016-11-30 08:41:35 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 09:06:56 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-30 09:07:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77a9da6b2061fe76134d89a942d78721fe3e42f0
Cr-Commit-Position: refs/heads/master@{#41377}

Powered by Google App Engine
This is Rietveld 408576698