Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2540793003: Make 'Inline Method' refactoring work with the new analysis driver. (Closed)

Created:
4 years ago by scheglov
Modified:
4 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make 'Inline Method' refactoring work with the new analysis driver. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0f9a78ff53f60101a954f2d9b20028083e6faf80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -10 lines) Patch
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_method.dart View 8 chunks +18 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/refactoring.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_method_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years ago (2016-11-30 01:07:26 UTC) #1
Brian Wilkerson
lgtm
4 years ago (2016-11-30 01:09:11 UTC) #2
scheglov
4 years ago (2016-11-30 01:12:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0f9a78ff53f60101a954f2d9b20028083e6faf80 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698