Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2540783003: Add iOS support to mac_toolchain download script. (Closed)

Created:
4 years ago by justincohen
Modified:
4 years ago
Reviewers:
erikchen
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add iOS support to mac_toolchain download script. Pull a different toolchain for target_os = iOS builds. BUG=669094 Committed: https://crrev.com/abbd93dcb51b18b634ff73853df13e8e5aec0d93 Cr-Commit-Position: refs/heads/master@{#435393}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update to latest iOS toolchain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -12 lines) Patch
M build/mac_toolchain.py View 1 3 chunks +41 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
justincohen
ptal https://codereview.chromium.org/2540783003/diff/1/build/mac_toolchain.py File build/mac_toolchain.py (right): https://codereview.chromium.org/2540783003/diff/1/build/mac_toolchain.py#newcode203 build/mac_toolchain.py:203: toolchain_version = os.environ.get('MAC_TOOLCHAIN_REVISION', With GN do we need ...
4 years ago (2016-11-30 01:38:10 UTC) #2
justincohen
Now with latest iOS package.
4 years ago (2016-11-30 18:56:16 UTC) #3
erikchen
lgtm
4 years ago (2016-11-30 19:00:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540783003/20001
4 years ago (2016-11-30 19:02:07 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 20:13:37 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-30 20:16:51 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/abbd93dcb51b18b634ff73853df13e8e5aec0d93
Cr-Commit-Position: refs/heads/master@{#435393}

Powered by Google App Engine
This is Rietveld 408576698