Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2540773002: Fix mus-in-renderer scale factor crash (Closed)

Created:
4 years ago by jonross
Modified:
4 years ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix mus-in-renderer scale factor crash Currently --mus-in-renderer crashes the renderer process on startup. The WindowTreeClient attempts to check the display scale factor, but the screen is not being set in that process. This change returns a default scale factor when there is no available screen. This will become redundant once aura-mus is ready, as proper screens will be available. TEST=manually ran --mus-in-renderer renderer works and paints. BUG=631270 Committed: https://crrev.com/d8cdf0429c899039b2b903888a680bce541c8cf4 Cr-Commit-Position: refs/heads/master@{#435102}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Jon needs to proof-read his comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M services/ui/public/cpp/window_tree_client.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jonross
Hey sky@, Could you provide an owners review for this change? Currently --mus-in-renderer is broken. ...
4 years ago (2016-11-29 18:35:16 UTC) #2
sky
LGTM https://codereview.chromium.org/2540773002/diff/1/services/ui/public/cpp/window_tree_client.cc File services/ui/public/cpp/window_tree_client.cc (right): https://codereview.chromium.org/2540773002/diff/1/services/ui/public/cpp/window_tree_client.cc#newcode46 services/ui/public/cpp/window_tree_client.cc:46: // is not being set properly for mus-in-rendered. ...
4 years ago (2016-11-29 20:27:47 UTC) #3
jonross
https://codereview.chromium.org/2540773002/diff/1/services/ui/public/cpp/window_tree_client.cc File services/ui/public/cpp/window_tree_client.cc (right): https://codereview.chromium.org/2540773002/diff/1/services/ui/public/cpp/window_tree_client.cc#newcode46 services/ui/public/cpp/window_tree_client.cc:46: // is not being set properly for mus-in-rendered. (http://crbug.com/659155) ...
4 years ago (2016-11-29 20:57:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540773002/20001
4 years ago (2016-11-29 20:58:47 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 23:07:57 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-29 23:12:10 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d8cdf0429c899039b2b903888a680bce541c8cf4
Cr-Commit-Position: refs/heads/master@{#435102}

Powered by Google App Engine
This is Rietveld 408576698