third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp - Issue 2540763002: Notifications: Split up image loading histograms by image type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp

Issue 2540763002: Notifications: Split up image loading histograms by image type (Closed)

Patch Set: git cl format Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp ('K') | « third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp ('k') | third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp b/third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp

index bcb59f4d19f6523ba1a2570ff293250865609682..73eb908f42a966d926355d4968300aef9fe5e6ad 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp

+++ b/third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp

@@ -35,7 +35,9 @@ class NotificationImageLoaderTest : public ::testing::Test {

public:

NotificationImageLoaderTest()

: m_page(DummyPageHolder::create()),

- m_loader(new NotificationImageLoader()) {}

+ // The type is only for UMA, so not interesting to test.

+ m_loader(

+ new NotificationImageLoader(NotificationImageLoader::Type::Icon)) {}

Peter Beverloo 2016/11/30 17:44:02 ISTM that testing that the right histogram is used

johnme 2016/11/30 19:08:36 Done.

~NotificationImageLoaderTest() override {

m_loader->stop();