tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 50c656f7c7a6c30490e717e4c25ee2631bfd9119..b5c0cf6f2119dd01e8e5b554522f18ea1aa4eab6 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -39049,11 +39049,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 </histogram>
 
 <histogram name="Notifications.Icon.FileSize" units="bytes">
+  <obsolete>
+    Deprecated Nov 2016 in favor of Notifications.LoadFileSize.*
+  </obsolete>
   <owner>peter@chromium.org</owner>
   <summary>The number of bytes loaded for a Web Notification icon.</summary>
 </histogram>
 
 <histogram name="Notifications.Icon.LoadFailTime" units="ms">
+  <obsolete>
+    Deprecated Nov 2016 in favor of Notifications.LoadFailTime.*
+  </obsolete>
   <owner>peter@chromium.org</owner>
   <summary>
     The number of milliseconds it took to fail loading an icon for a Web
@@ -39062,6 +39068,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 </histogram>
 
 <histogram name="Notifications.Icon.LoadFinishTime" units="ms">
+  <obsolete>
+    Deprecated Nov 2016 in favor of Notifications.LoadFinishTime.*
+  </obsolete>
   <owner>peter@chromium.org</owner>
   <summary>
     The number of milliseconds it took to finish successfully loading an icon
@@ -39070,6 +39079,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 </histogram>
 
 <histogram name="Notifications.Icon.ScaleDownTime" units="ms">
+  <obsolete>
+    Deprecated Nov 2016 in favor of Notifications.LoadScaleDownTime.*
+  </obsolete>
   <owner>peter@chromium.org</owner>
   <summary>
     The number of milliseconds it took to scale down an icon for a Web
@@ -39077,6 +39089,126 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="Notifications.LoadFailTime.ActionIcon" units="ms">
+  <owner>johnme@chromium.org</owner>
+  <summary>
+    The number of milliseconds it took to fail loading an action icon for a Web
+    Notification.
+  </summary>
+</histogram>
+
+<histogram name="Notifications.LoadFailTime.Badge" units="ms">
+  <owner>johnme@chromium.org</owner>
+  <summary>
+    The number of milliseconds it took to fail loading a badge for a Web
+    Notification.
+  </summary>
+</histogram>
+
+<histogram name="Notifications.LoadFailTime.Icon" units="ms">
+  <owner>johnme@chromium.org</owner>
+  <summary>
+    The number of milliseconds it took to fail loading an icon for a Web
+    Notification.
+  </summary>
+</histogram>
+
+<histogram name="Notifications.LoadFailTime.Image" units="ms">
+  <owner>johnme@chromium.org</owner>
+  <summary>
+    The number of milliseconds it took to fail loading a content image for a Web
+    Notification.
+  </summary>
+</histogram>
+
+<histogram name="Notifications.LoadFileSize.ActionIcon" units="bytes">
+  <owner>johnme@chromium.org</owner>
+  <summary>
+    The number of bytes loaded for a Web Notification action icon.
+  </summary>
+</histogram>
+
+<histogram name="Notifications.LoadFileSize.Badge" units="bytes">
+  <owner>johnme@chromium.org</owner>
+  <summary>The number of bytes loaded for a Web Notification badge.</summary>
+</histogram>
+
+<histogram name="Notifications.LoadFileSize.Icon" units="bytes">
+  <owner>johnme@chromium.org</owner>
+  <summary>The number of bytes loaded for a Web Notification icon.</summary>
+</histogram>
+
+<histogram name="Notifications.LoadFileSize.Image" units="bytes">
+  <owner>johnme@chromium.org</owner>
+  <summary>
+    The number of bytes loaded for a Web Notification content image.
+  </summary>
+</histogram>
+
+<histogram name="Notifications.LoadFinishTime.ActionIcon" units="ms">
+  <owner>johnme@chromium.org</owner>
+  <summary>
+    The number of milliseconds it took to finish successfully loading an action
+    icon for a Web Notification.
+  </summary>
+</histogram>
+
+<histogram name="Notifications.LoadFinishTime.Badge" units="ms">
+  <owner>johnme@chromium.org</owner>
+  <summary>
+    The number of milliseconds it took to finish successfully loading a badge
+    for a Web Notification.
+  </summary>
+</histogram>
+
+<histogram name="Notifications.LoadFinishTime.Icon" units="ms">
+  <owner>johnme@chromium.org</owner>
+  <summary>
+    The number of milliseconds it took to finish successfully loading an icon
+    for a Web Notification.
+  </summary>
+</histogram>
+
+<histogram name="Notifications.LoadFinishTime.Image" units="ms">
+  <owner>johnme@chromium.org</owner>
+  <summary>
+    The number of milliseconds it took to finish successfully loading a content
+    image for a Web Notification.
+  </summary>
+</histogram>
+
+<histogram name="Notifications.LoadScaleDownTime.ActionIcon" units="ms">
+  <owner>johnme@chromium.org</owner>
+  <summary>
+    The number of milliseconds it took to scale down an action icon for a Web
+    Notification.
+  </summary>
+</histogram>
+
+<histogram name="Notifications.LoadScaleDownTime.Badge" units="ms">
+  <owner>johnme@chromium.org</owner>
+  <summary>
+    The number of milliseconds it took to scale down a badge for a Web
+    Notification.
+  </summary>
+</histogram>
+
+<histogram name="Notifications.LoadScaleDownTime.Icon" units="ms">
+  <owner>johnme@chromium.org</owner>
+  <summary>
+    The number of milliseconds it took to scale down an icon for a Web
+    Notification.
+  </summary>
+</histogram>
+
+<histogram name="Notifications.LoadScaleDownTime.Image" units="ms">
+  <owner>johnme@chromium.org</owner>
+  <summary>
+    The number of milliseconds it took to scale down a content image for a Web
+    Notification.
+  </summary>
+</histogram>

[Ilya Sherman, 2016/12/01 01:00:45]

Could you please use histogram_suffixes to reduce the amount of repetition from
these histograms?

[johnme, 2016/12/01 11:53:49]

Done, though a downside is that histogram_suffixes also generates unsuffixed
histograms, so there are now histograms called Notifications.LoadFailTime etc
that will never have data uploaded to them. This seems to affect many other
users of histogram suffixes from cursory inspection of the UMA dashboard.

[Ilya Sherman, 2016/12/02 01:24:32]

Ah, to work around this you can add an attribute base='true'.  It's a recently
added trick =)

+
 <histogram name="Notifications.PerNotificationActions"
     enum="NotificationActionType">
   <owner>dewittj@chromium.org</owner>