Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2540743003:
Reland of land "[wrapper-tracing] Enable flag per default" (Closed)
|
Created:
4 years ago by Michael Lippautz Modified:
4 years ago CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReland of land "[wrapper-tracing] Enable flag per default" (patchset #2 id:150001 of https://codereview.chromium.org/2528393002/ )
Reason for revert:
Dev release happened. Enabling again.
Original issue's description:
> Revert of Reland "[wrapper-tracing] Enable flag per default" (patchset #1 id:20001 of https://codereview.chromium.org/2503043002/ )
>
> Reason for revert:
> Reverting because of upcomming Dev release. Will re-enable tomorrow after the release is done.
>
> Original issue's description:
> > Reland "[wrapper-tracing] Enable flag per default"
> >
> > BUG=chromium:468240
> >
> > Committed: https://crrev.com/e23de6962be8b4967127ae95040f32bbb533b4d1
> > Cr-Commit-Position: refs/heads/master@{#433823}
>
> TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=chromium:468240, chromium:668060, chromium:668059
>
> Committed: https://crrev.com/2b5aa49038a8dd31697e3b9d636a26750a4ecdaa
> Cr-Commit-Position: refs/heads/master@{#434640}
TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:468240, chromium:668060, chromium:668059
Committed: https://crrev.com/6dade445294d2a029c8c9407497ea7b883afe7ad
Committed: https://crrev.com/d5f90d2760d39d11495039928fd5d9d777da7329
Cr-Original-Commit-Position: refs/heads/master@{#435105}
Cr-Commit-Position: refs/heads/master@{#436554}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : Rebase #
Messages
Total messages: 27 (15 generated)
The CQ bit was checked by mlippautz@chromium.org
Created Reland of land "[wrapper-tracing] Enable flag per default"
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by mlippautz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1480454318640350,
"parent_rev": "48ad1966813bf7ac1d55b061c45be242e23aeade", "commit_rev":
"138a81aaf6b569b6cc192ffa70ec7b65532cc5dc"}
Message was sent while issue was closed.
Committed patchset #2 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== Reland of land "[wrapper-tracing] Enable flag per default" (patchset #2 id:150001 of https://codereview.chromium.org/2528393002/ ) Reason for revert: Dev release happened. Enabling again. Original issue's description: > Revert of Reland "[wrapper-tracing] Enable flag per default" (patchset #1 id:20001 of https://codereview.chromium.org/2503043002/ ) > > Reason for revert: > Reverting because of upcomming Dev release. Will re-enable tomorrow after the release is done. > > Original issue's description: > > Reland "[wrapper-tracing] Enable flag per default" > > > > BUG=chromium:468240 > > > > Committed: https://crrev.com/e23de6962be8b4967127ae95040f32bbb533b4d1 > > Cr-Commit-Position: refs/heads/master@{#433823} > > TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chrom... > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=chromium:468240, chromium:668060, chromium:668059 > > Committed: https://crrev.com/2b5aa49038a8dd31697e3b9d636a26750a4ecdaa > Cr-Commit-Position: refs/heads/master@{#434640} TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chrom... # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:468240, chromium:668060, chromium:668059 ========== to ========== Reland of land "[wrapper-tracing] Enable flag per default" (patchset #2 id:150001 of https://codereview.chromium.org/2528393002/ ) Reason for revert: Dev release happened. Enabling again. Original issue's description: > Revert of Reland "[wrapper-tracing] Enable flag per default" (patchset #1 id:20001 of https://codereview.chromium.org/2503043002/ ) > > Reason for revert: > Reverting because of upcomming Dev release. Will re-enable tomorrow after the release is done. > > Original issue's description: > > Reland "[wrapper-tracing] Enable flag per default" > > > > BUG=chromium:468240 > > > > Committed: https://crrev.com/e23de6962be8b4967127ae95040f32bbb533b4d1 > > Cr-Commit-Position: refs/heads/master@{#433823} > > TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chrom... > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=chromium:468240, chromium:668060, chromium:668059 > > Committed: https://crrev.com/2b5aa49038a8dd31697e3b9d636a26750a4ecdaa > Cr-Commit-Position: refs/heads/master@{#434640} TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chrom... # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:468240, chromium:668060, chromium:668059 Committed: https://crrev.com/6dade445294d2a029c8c9407497ea7b883afe7ad Cr-Commit-Position: refs/heads/master@{#435105} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6dade445294d2a029c8c9407497ea7b883afe7ad Cr-Commit-Position: refs/heads/master@{#435105}
Message was sent while issue was closed.
LGTM
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:120001) has been created in https://codereview.chromium.org/2534323002/ by kbr@chromium.org. The reason for reverting is: Causing intermittent crashes, for example: https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release... https://chromium-swarm.appspot.com/task?id=32cb6753713de310&refresh=10&show_r... WebglConformance_deqp_functional_gles3_fborender_shared_colorbuffer_02 (gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest) ... [27198:775:1129/161828:FATAL:ScriptWrappableVisitor.h(168)] Check failed: false. 0 Chromium Framework 0x00000001065df623 _ZN4base5debug10StackTraceC1Ev + 19 1 Chromium Framework 0x00000001066031d7 _ZN7logging10LogMessageD2Ev + 71 2 Chromium Framework 0x000000010a10902c _ZThn8_NK5blink22ScriptWrappableVisitor21dispatchTraceWrappersEPKv + 76 3 Chromium Framework 0x000000010a1080e5 _ZN5blink22ScriptWrappableVisitor14AdvanceTracingEdN2v818EmbedderHeapTracer21AdvanceTracingActionsE + 293 4 Chromium Framework 0x0000000104c898a3 _ZN2v88internal18IncrementalMarking4StepEmNS1_16CompletionActionENS1_21ForceCompletionActionENS0_10StepOriginE + 1475 5 Chromium Framework 0x0000000104c89e7b _ZN2v88internal18IncrementalMarking37AdvanceIncrementalMarkingOnAllocationEv + 363 6 Chromium Framework 0x0000000104cd5fed _ZN2v88internal8NewSpace16EnsureAllocationEiNS0_19AllocationAlignmentE + 429 7 Chromium Framework 0x0000000104c2e23f _ZN2v88internal4Heap11AllocateRawEiNS0_15AllocationSpaceENS0_19AllocationAlignmentE + 335 8 Chromium Framework 0x0000000104c69c6f _ZN2v88internal4Heap20AllocateFillerObjectEibNS0_15AllocationSpaceE + 31 9 Chromium Framework 0x0000000104c0cb7d _ZN2v88internal7Factory15NewFillerObjectEibNS0_15AllocationSpaceE + 45 10 Chromium Framework 0x0000000104f4b279 _ZN2v88internalL36__RT_impl_Runtime_AllocateInNewSpaceENS0_9ArgumentsEPNS0_7IsolateE + 89 11 Chromium Framework 0x0000000104f4af8e _ZN2v88internal26Runtime_AllocateInNewSpaceEiPPNS0_6ObjectEPNS0_7IsolateE + 238 12 ??? 0x000022c3837043a7 0x0 + 38223119139751 13 ??? 0x000022c3838ccbcb 0x0 + 38223121009611 14 ??? 0x000022c3842c5061 0x0 + 38223131463777 .
Message was sent while issue was closed.
Description was changed from ========== Reland of land "[wrapper-tracing] Enable flag per default" (patchset #2 id:150001 of https://codereview.chromium.org/2528393002/ ) Reason for revert: Dev release happened. Enabling again. Original issue's description: > Revert of Reland "[wrapper-tracing] Enable flag per default" (patchset #1 id:20001 of https://codereview.chromium.org/2503043002/ ) > > Reason for revert: > Reverting because of upcomming Dev release. Will re-enable tomorrow after the release is done. > > Original issue's description: > > Reland "[wrapper-tracing] Enable flag per default" > > > > BUG=chromium:468240 > > > > Committed: https://crrev.com/e23de6962be8b4967127ae95040f32bbb533b4d1 > > Cr-Commit-Position: refs/heads/master@{#433823} > > TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chrom... > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=chromium:468240, chromium:668060, chromium:668059 > > Committed: https://crrev.com/2b5aa49038a8dd31697e3b9d636a26750a4ecdaa > Cr-Commit-Position: refs/heads/master@{#434640} TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chrom... # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:468240, chromium:668060, chromium:668059 Committed: https://crrev.com/6dade445294d2a029c8c9407497ea7b883afe7ad Cr-Commit-Position: refs/heads/master@{#435105} ========== to ========== Reland of land "[wrapper-tracing] Enable flag per default" (patchset #2 id:150001 of https://codereview.chromium.org/2528393002/ ) Reason for revert: Dev release happened. Enabling again. Original issue's description: > Revert of Reland "[wrapper-tracing] Enable flag per default" (patchset #1 id:20001 of https://codereview.chromium.org/2503043002/ ) > > Reason for revert: > Reverting because of upcomming Dev release. Will re-enable tomorrow after the release is done. > > Original issue's description: > > Reland "[wrapper-tracing] Enable flag per default" > > > > BUG=chromium:468240 > > > > Committed: https://crrev.com/e23de6962be8b4967127ae95040f32bbb533b4d1 > > Cr-Commit-Position: refs/heads/master@{#433823} > > TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chrom... > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=chromium:468240, chromium:668060, chromium:668059 > > Committed: https://crrev.com/2b5aa49038a8dd31697e3b9d636a26750a4ecdaa > Cr-Commit-Position: refs/heads/master@{#434640} TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chrom... # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:468240, chromium:668060, chromium:668059 Committed: https://crrev.com/6dade445294d2a029c8c9407497ea7b883afe7ad Cr-Commit-Position: refs/heads/master@{#435105} ==========
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2540743003/#ps140001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 140001, "attempt_start_ts": 1481016428191740,
"parent_rev": "bdf90b0252f94646bec758a0bf37a0493451cb4c", "commit_rev":
"60141dbe3082d55b5609fb14be0cb7dbad277f8b"}
Message was sent while issue was closed.
Description was changed from ========== Reland of land "[wrapper-tracing] Enable flag per default" (patchset #2 id:150001 of https://codereview.chromium.org/2528393002/ ) Reason for revert: Dev release happened. Enabling again. Original issue's description: > Revert of Reland "[wrapper-tracing] Enable flag per default" (patchset #1 id:20001 of https://codereview.chromium.org/2503043002/ ) > > Reason for revert: > Reverting because of upcomming Dev release. Will re-enable tomorrow after the release is done. > > Original issue's description: > > Reland "[wrapper-tracing] Enable flag per default" > > > > BUG=chromium:468240 > > > > Committed: https://crrev.com/e23de6962be8b4967127ae95040f32bbb533b4d1 > > Cr-Commit-Position: refs/heads/master@{#433823} > > TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chrom... > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=chromium:468240, chromium:668060, chromium:668059 > > Committed: https://crrev.com/2b5aa49038a8dd31697e3b9d636a26750a4ecdaa > Cr-Commit-Position: refs/heads/master@{#434640} TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chrom... # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:468240, chromium:668060, chromium:668059 Committed: https://crrev.com/6dade445294d2a029c8c9407497ea7b883afe7ad Cr-Commit-Position: refs/heads/master@{#435105} ========== to ========== Reland of land "[wrapper-tracing] Enable flag per default" (patchset #2 id:150001 of https://codereview.chromium.org/2528393002/ ) Reason for revert: Dev release happened. Enabling again. Original issue's description: > Revert of Reland "[wrapper-tracing] Enable flag per default" (patchset #1 id:20001 of https://codereview.chromium.org/2503043002/ ) > > Reason for revert: > Reverting because of upcomming Dev release. Will re-enable tomorrow after the release is done. > > Original issue's description: > > Reland "[wrapper-tracing] Enable flag per default" > > > > BUG=chromium:468240 > > > > Committed: https://crrev.com/e23de6962be8b4967127ae95040f32bbb533b4d1 > > Cr-Commit-Position: refs/heads/master@{#433823} > > TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chrom... > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=chromium:468240, chromium:668060, chromium:668059 > > Committed: https://crrev.com/2b5aa49038a8dd31697e3b9d636a26750a4ecdaa > Cr-Commit-Position: refs/heads/master@{#434640} TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chrom... # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:468240, chromium:668060, chromium:668059 Committed: https://crrev.com/6dade445294d2a029c8c9407497ea7b883afe7ad Cr-Commit-Position: refs/heads/master@{#435105} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:140001)
Message was sent while issue was closed.
Description was changed from ========== Reland of land "[wrapper-tracing] Enable flag per default" (patchset #2 id:150001 of https://codereview.chromium.org/2528393002/ ) Reason for revert: Dev release happened. Enabling again. Original issue's description: > Revert of Reland "[wrapper-tracing] Enable flag per default" (patchset #1 id:20001 of https://codereview.chromium.org/2503043002/ ) > > Reason for revert: > Reverting because of upcomming Dev release. Will re-enable tomorrow after the release is done. > > Original issue's description: > > Reland "[wrapper-tracing] Enable flag per default" > > > > BUG=chromium:468240 > > > > Committed: https://crrev.com/e23de6962be8b4967127ae95040f32bbb533b4d1 > > Cr-Commit-Position: refs/heads/master@{#433823} > > TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chrom... > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=chromium:468240, chromium:668060, chromium:668059 > > Committed: https://crrev.com/2b5aa49038a8dd31697e3b9d636a26750a4ecdaa > Cr-Commit-Position: refs/heads/master@{#434640} TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chrom... # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:468240, chromium:668060, chromium:668059 Committed: https://crrev.com/6dade445294d2a029c8c9407497ea7b883afe7ad Cr-Commit-Position: refs/heads/master@{#435105} ========== to ========== Reland of land "[wrapper-tracing] Enable flag per default" (patchset #2 id:150001 of https://codereview.chromium.org/2528393002/ ) Reason for revert: Dev release happened. Enabling again. Original issue's description: > Revert of Reland "[wrapper-tracing] Enable flag per default" (patchset #1 id:20001 of https://codereview.chromium.org/2503043002/ ) > > Reason for revert: > Reverting because of upcomming Dev release. Will re-enable tomorrow after the release is done. > > Original issue's description: > > Reland "[wrapper-tracing] Enable flag per default" > > > > BUG=chromium:468240 > > > > Committed: https://crrev.com/e23de6962be8b4967127ae95040f32bbb533b4d1 > > Cr-Commit-Position: refs/heads/master@{#433823} > > TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chrom... > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=chromium:468240, chromium:668060, chromium:668059 > > Committed: https://crrev.com/2b5aa49038a8dd31697e3b9d636a26750a4ecdaa > Cr-Commit-Position: refs/heads/master@{#434640} TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chrom... # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:468240, chromium:668060, chromium:668059 Committed: https://crrev.com/6dade445294d2a029c8c9407497ea7b883afe7ad Committed: https://crrev.com/d5f90d2760d39d11495039928fd5d9d777da7329 Cr-Original-Commit-Position: refs/heads/master@{#435105} Cr-Commit-Position: refs/heads/master@{#436554} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/d5f90d2760d39d11495039928fd5d9d777da7329 Cr-Commit-Position: refs/heads/master@{#436554}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:140001) has been created in https://codereview.chromium.org/2562713003/ by mlippautz@chromium.org. The reason for reverting is: Revert for upcomming dev release.. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
