Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 254073003: Revert of Improve Android scripts: (Closed)

Created:
6 years, 7 months ago by hal.canary
Modified:
6 years, 7 months ago
Reviewers:
scroggo, djsollen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Improve Android scripts: (https://codereview.chromium.org/254923003/) Reason for revert: errors Original issue's description: > Improve Android scripts: > > * android_gdbserver: > - Don't complain if $GDB_TMP_DIR already exists > - Since $GDB_TMP_DIR/gdb.setup might already exist, overwrite the file. > > * android_run_skia: > - Move resource files onto the device. > - Change to tmp directory before executing program. > > * android_make, android_setup: > - stop assuming PWD is skia source directory. > > NOTRY=true > > Committed: http://code.google.com/p/skia/source/detail?r=14442 TBR=djsollen@google.com,scroggo@google.com NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14448

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -27 lines) Patch
M platform_tools/android/bin/android_gdb_exe View 1 chunk +8 lines, -12 lines 0 comments Download
M platform_tools/android/bin/android_gdbserver View 1 chunk +1 line, -1 line 0 comments Download
M platform_tools/android/bin/android_make View 1 chunk +1 line, -2 lines 0 comments Download
M platform_tools/android/bin/android_run_skia View 2 chunks +1 line, -8 lines 0 comments Download
M platform_tools/android/bin/android_setup.sh View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hal.canary
Created Revert of Improve Android scripts:
6 years, 7 months ago (2014-04-29 20:59:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/254073003/1
6 years, 7 months ago (2014-04-29 20:59:53 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 21:00:08 UTC) #3
Message was sent while issue was closed.
Change committed as 14448

Powered by Google App Engine
This is Rietveld 408576698