Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2540713003: Revert of Propagate information about how ARC apps are launched (Closed)

Created:
4 years ago by battre
Modified:
4 years ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, sadrul, yusukes+watch_chromium.org, tdresser+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org, Matt Giuca, sky
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Propagate information about how ARC apps are launched (patchset #8 id:130001 of https://codereview.chromium.org/2540433002/ ) Reason for revert: Memory use after free (http://crbug.com/669146#c2) Original issue's description: > Propagate information about how ARC apps are launched > > This change lets ARC know whether an app should be launched in Touch > Mode[1] or not. > > 1: http://android-developers.blogspot.com/2008/12/touch-mode.html > > BUG=669146 > TEST=ARC app starts in touch mode when activated using > mouse/trackpad/touch > TEST=ARC app starts in focus mode when activated using > keyboard. > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/b5898c35b2415dbf8b5d9aaa19a6b13b0510d1e7 > Cr-Commit-Position: refs/heads/master@{#435115} TBR=stevenjb@chromium.org,khmel@chromium.org,lhchavez@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=669146 Committed: https://crrev.com/311c923c1a38e0fe90a45559d09b1cd0360b8db4 Cr-Commit-Position: refs/heads/master@{#435157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -158 lines) Patch
M chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_launcher.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_utils.h View 2 chunks +7 lines, -12 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_utils.cc View 14 chunks +28 lines, -81 lines 0 comments Download
M chrome/browser/ui/app_list/search/arc_app_result.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.h View 3 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_item_controller.h View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_item_controller.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 7 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_controller_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
battre
Created Revert of Propagate information about how ARC apps are launched
4 years ago (2016-11-30 08:11:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540713003/1
4 years ago (2016-11-30 08:12:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 08:15:16 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-30 08:17:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/311c923c1a38e0fe90a45559d09b1cd0360b8db4
Cr-Commit-Position: refs/heads/master@{#435157}

Powered by Google App Engine
This is Rietveld 408576698