Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1467)

Unified Diff: content/public/test/browser_test_utils.cc

Issue 2540683002: Don't defer quitting in ExecuteScript and other helpers that use DOMMessageQueue. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/cryptohome/mock_homedir_methods.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/browser_test_utils.cc
diff --git a/content/public/test/browser_test_utils.cc b/content/public/test/browser_test_utils.cc
index a4bf937b458328261bb3ca355013b0783f191fe9..7d066fe1efd414f6abb311af94bc09f107b83b1d 100644
--- a/content/public/test/browser_test_utils.cc
+++ b/content/public/test/browser_test_utils.cc
@@ -1323,7 +1323,8 @@ bool DOMMessageQueue::WaitForMessage(std::string* message) {
DCHECK(message);
if (message_queue_.empty()) {
// This will be quit when a new message comes in.
- message_loop_runner_ = new MessageLoopRunner;
+ message_loop_runner_ =
+ new MessageLoopRunner(MessageLoopRunner::QuitMode::IMMEDIATE);
message_loop_runner_->Run();
}
// The queue should not be empty, unless we were quit because of a timeout.
« no previous file with comments | « chromeos/cryptohome/mock_homedir_methods.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698