Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2540673002: Disable flaky AutofillManagerTest.CreditCardSavedWhenAutocompleteOff (Closed)

Created:
4 years ago by battre
Modified:
4 years ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky AutofillManagerTest.CreditCardSavedWhenAutocompleteOff [ RUN ] AutofillManagerTest.CreditCardSavedWhenAutocompleteOff ../../components/autofill/core/browser/autofill_manager_unittest.cc:3695: Failure Actual function call count doesn't match EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _))... Expected: to be called once Actual: never called - unsatisfied and active BUG=666704 TBR=mathp@chromium.org Committed: https://crrev.com/30a937312f5992b685cc7c2fed1ec9972681b10c Cr-Commit-Position: refs/heads/master@{#434981}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 chunk +9 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
This CL has an open dependency (Issue 2533253002 Patch 1). Please resolve the dependency and ...
4 years ago (2016-11-29 12:34:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540673002/1
4 years ago (2016-11-29 13:22:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 13:56:32 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-29 14:00:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30a937312f5992b685cc7c2fed1ec9972681b10c
Cr-Commit-Position: refs/heads/master@{#434981}

Powered by Google App Engine
This is Rietveld 408576698