Implement collection of out-of-flow descendants

third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/ng/ng_block_layout_algorithm.h"
 
 #include "core/layout/ng/ng_break_token.h"
 #include "core/layout/ng/ng_constraint_space.h"
 #include "core/layout/ng/ng_constraint_space_builder.h"
 #include "core/layout/ng/ng_fragment_base.h"
@@ skipping 145 matching lines @@
   //    (https://drafts.csswg.org/css-multicol-1/#valdef-column-span-all)
 
   if (style.specifiesColumns() || style.containsPaint() ||
       style.containsLayout())
     return true;
 
   if (!style.isOverflowVisible())
     return true;
 
   EDisplay display = style.display();
+

[ikilpatrick, 2016/12/02 17:47:05]

remove from this patch.

[atotic, 2016/12/02 19:55:15]

done

   if (display == EDisplay::Grid || display == EDisplay::Flex ||
       display == EDisplay::WebkitBox)
     return true;
 
   if (space.WritingMode() != FromPlatformWritingMode(style.getWritingMode()))
     return true;
 
   return false;
 }
 
@@ skipping 14 matching lines @@
 }
 
 NGLayoutStatus NGBlockLayoutAlgorithm::Layout(
     NGFragmentBase*,
     NGPhysicalFragmentBase** fragment_out,
     NGLayoutAlgorithm**) {
   switch (state_) {
     case kStateInit: {
       border_and_padding_ =
           ComputeBorders(Style()) + ComputePadding(ConstraintSpace(), Style());
-

[ikilpatrick, 2016/12/02 17:47:05]

remove from this patch.

[atotic, 2016/12/02 19:55:15]

done

       WTF::Optional<MinAndMaxContentSizes> sizes;
       if (NeedMinAndMaxContentSizes(Style())) {
         // TODOO(layout-ng): Implement
         sizes = MinAndMaxContentSizes();
       }
       LayoutUnit inline_size =
           ComputeInlineSizeForFragment(ConstraintSpace(), Style(), sizes);
       LayoutUnit adjusted_inline_size =
           inline_size - border_and_padding_.InlineSum();
       // TODO(layout-ng): For quirks mode, should we pass blockSize instead of
@@ skipping 27 matching lines @@
       builder_->SetInlineSize(inline_size).SetBlockSize(block_size);
       current_child_ = first_child_;
       if (current_child_)
         space_for_current_child_ = CreateConstraintSpaceForCurrentChild();
 
       state_ = kStateChildLayout;
       return kNotFinished;
     }
     case kStateChildLayout: {
       if (current_child_) {
+        // TODO(atotic): uncomment this code when implementing oof layout.
+        // This code cannot be turned on because it prevents layout of
+        // oof children, and non-layedout objects trigger  a DCHECK.
+        // EPosition position = current_child_->Style()->position();
+        // if ((position == AbsolutePosition || position == FixedPosition)) {
+        //   builder_->AddOutOfFlowCandidateChild(current_child_,
+        //   GetChildSpaceOffset());
+        // }
+        // else
         if (!LayoutCurrentChild())
           return kNotFinished;
         current_child_ = current_child_->NextSibling();
         if (current_child_) {
           space_for_current_child_ = CreateConstraintSpaceForCurrentChild();
           return kNotFinished;
         }
       }
       state_ = kStateFinalize;
       return kNotFinished;
@@ skipping 169 matching lines @@
 NGBlockLayoutAlgorithm::CreateConstraintSpaceForCurrentChild() const {
   DCHECK(current_child_);
   space_builder_->SetIsNewFormattingContext(
       IsNewFormattingContextForInFlowBlockLevelChild(ConstraintSpace(),
                                                      CurrentChildStyle()));
   NGConstraintSpace* child_space = new NGConstraintSpace(
       constraint_space_->WritingMode(), constraint_space_->Direction(),
       space_builder_->ToConstraintSpace());
 
   // TODO(layout-ng): Set offset through the space builder.
-  child_space->SetOffset(
-      NGLogicalOffset(border_and_padding_.inline_start, content_size_));
+  child_space->SetOffset(GetChildSpaceOffset());
 
   // TODO(layout-ng): avoid copying here. A child and parent constraint spaces
   // should share the same backing space.
   for (const auto& exclusion : constraint_space_->Exclusions()) {
     child_space->AddExclusion(*exclusion.get());
   }
   return child_space;
 }
 
 DEFINE_TRACE(NGBlockLayoutAlgorithm) {
   NGLayoutAlgorithm::trace(visitor);
   visitor->trace(first_child_);
   visitor->trace(constraint_space_);
   visitor->trace(break_token_);
   visitor->trace(builder_);
   visitor->trace(space_builder_);
   visitor->trace(space_for_current_child_);
   visitor->trace(current_child_);
 }
 
 }  // namespace blink