Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2540653002: Revert of Script blocking resources tracking should be only done by Document::isScriptExecutionReady (Closed)

Created:
4 years ago by battre
Modified:
4 years ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Script blocking resources tracking should be only done by Document::isScriptExecutionReady (patchset #3 id:40001 of https://codereview.chromium.org/2536753003/ ) Reason for revert: Speculative revert for crbug.com/669435. BUG=669435 Original issue's description: > Script blocking resources tracking should be only done by Document::isScriptExecutionReady > > Before this CL, we had a duplicated tracking flag > HTMLScriptRunner::m_hasScriptsWaitingForResources. > > This CL removes the flag in HTMLScriptRunner and changes code so it checks > Document::isScriptExecutionReady() state instead. > > This CL also removes a comment referring to HTMLDocumentParser::executeScriptsWaitingForResources > being called when it hasScriptsWaitingForResources as it should never happen > and replaces it with a DCHECK > > BUG=None > > Committed: https://crrev.com/74341a4386cbe0c0b94eba0535fbbbf8d1aff8ea > Cr-Commit-Position: refs/heads/master@{#434935} TBR=dominicc@chromium.org,yhirano@chromium.org,kouhei@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/acbd50fc4a51624a65c53ec760cff2bec03ae943 Cr-Commit-Position: refs/heads/master@{#434960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -23 lines) Patch
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 3 chunks +9 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.h View 3 chunks +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp View 5 chunks +17 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
battre
Created Revert of Script blocking resources tracking should be only done by Document::isScriptExecutionReady
4 years ago (2016-11-29 11:41:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540653002/1
4 years ago (2016-11-29 11:41:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 11:42:52 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-29 12:22:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/acbd50fc4a51624a65c53ec760cff2bec03ae943
Cr-Commit-Position: refs/heads/master@{#434960}

Powered by Google App Engine
This is Rietveld 408576698