Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2540643002: Added CHANGELOG.md entry for initializing formal access. (Closed)

Created:
4 years ago by eernst
Modified:
4 years ago
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Whitespace fix #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M CHANGELOG.md View 1 1 chunk +5 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
eernst
PS: This will ONLY be landed in 1.21 if all tools are ready. This CL ...
4 years ago (2016-11-29 11:12:08 UTC) #2
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/2540643002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2540643002/diff/1/CHANGELOG.md#newcode6 CHANGELOG.md:6: `y` in `class C { var x,y; C(this.x): ...
4 years ago (2016-11-29 11:17:28 UTC) #3
eernst
Review response. https://codereview.chromium.org/2540643002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2540643002/diff/1/CHANGELOG.md#newcode6 CHANGELOG.md:6: `y` in `class C { var x,y; ...
4 years ago (2016-11-29 11:36:37 UTC) #4
kevmoo
lgtm https://codereview.chromium.org/2540643002/diff/20001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2540643002/diff/20001/CHANGELOG.md#newcode5 CHANGELOG.md:5: * Support access to initializing formals, e.g., the ...
4 years ago (2016-11-29 16:28:40 UTC) #5
eernst
Review response. https://codereview.chromium.org/2540643002/diff/20001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2540643002/diff/20001/CHANGELOG.md#newcode5 CHANGELOG.md:5: * Support access to initializing formals, e.g., ...
4 years ago (2016-11-30 10:46:05 UTC) #6
eernst
4 years ago (2016-11-30 10:47:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2812738546a2ff499c2a1667e9c73786704b7732 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698