Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 2540623002: Fix speech-synthesis-speak-multiple.html flakiness. (Closed)

Created:
4 years ago by sof
Modified:
4 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix speech-synthesis-speak-multiple.html flakiness. Follow up on r420711 (crbug.com/589632) and adjust the expected lower bound on ".elapsedTime" to also include zero for 'start' events. TBR=dmazzoni BUG=660448 Committed: https://crrev.com/4431896b154b5c4a4604f8812fc39b0399be9830 Cr-Commit-Position: refs/heads/master@{#434931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-speak-multiple.html View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-speak-multiple-expected.txt View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years ago (2016-11-29 07:51:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540623002/1
4 years ago (2016-11-29 07:51:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 08:48:53 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4431896b154b5c4a4604f8812fc39b0399be9830 Cr-Commit-Position: refs/heads/master@{#434931}
4 years ago (2016-11-29 09:34:34 UTC) #7
dmazzoni
4 years ago (2016-11-29 16:12:23 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698