Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2540613002:
Re-factor Editor::unappliedEditing() (Closed)
|
Created:
4 years ago by yosin_UTC9 Modified:
4 years ago CC:
blink-reviews, chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRe-factor Editor::unappliedEditing()
This patch changes |Editor::unappliedEditing()| to use |isNone()| predicate
rather than checking |Document| equality of |Position| to simplify source code
for improving code health.
Since |correctVisibleSelection()| always returns |VisibileSlection| which
is an empty or valid for specified |Document|, checking equality of |Document|
between selection start and |frame.document()| is equivalent to empty selection
check.
BUG=n/a
TEST=n/a; no behavior changes
Committed: https://crrev.com/ad9144ea0891e682751beec341342e7021d160a0
Cr-Commit-Position: refs/heads/master@{#434961}
Patch Set 1 : 2016-11-29T17:47:51 #
Messages
Total messages: 22 (17 generated)
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from ========== 2016-11-29T14:18:46 BUG= ========== to ========== Re-factor Editor::unappliedEditing() This patch changes |Editor::unappliedEditing()| to use |isNone()| predicate rather than checking |Document| equality of |Position| to simplify source code for improving code health. Since |correctVisibleSelection()| always returns |VisibileSlection| which is an empty or valid for specified |Document|, checking equality of |Document| between selection start and |frame.document()| is equivalent to empty selection check. BUG=n/a TEST=n/a; no behavior changes ==========
yosin@chromium.org changed reviewers: + xiaochengh@chromium.org, yoichio@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xiaochengh@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480419660061600,
"parent_rev": "32ca25cec20de4fb2bf037864e787c11b0b94d4b", "commit_rev":
"0631cf6bc5973e4daae3f1bf2ff556055af3722f"}
Message was sent while issue was closed.
Committed patchset #1 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Re-factor Editor::unappliedEditing() This patch changes |Editor::unappliedEditing()| to use |isNone()| predicate rather than checking |Document| equality of |Position| to simplify source code for improving code health. Since |correctVisibleSelection()| always returns |VisibileSlection| which is an empty or valid for specified |Document|, checking equality of |Document| between selection start and |frame.document()| is equivalent to empty selection check. BUG=n/a TEST=n/a; no behavior changes ========== to ========== Re-factor Editor::unappliedEditing() This patch changes |Editor::unappliedEditing()| to use |isNone()| predicate rather than checking |Document| equality of |Position| to simplify source code for improving code health. Since |correctVisibleSelection()| always returns |VisibileSlection| which is an empty or valid for specified |Document|, checking equality of |Document| between selection start and |frame.document()| is equivalent to empty selection check. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/ad9144ea0891e682751beec341342e7021d160a0 Cr-Commit-Position: refs/heads/master@{#434961} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ad9144ea0891e682751beec341342e7021d160a0 Cr-Commit-Position: refs/heads/master@{#434961} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
