Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2960)

Unified Diff: content/shell/android/java/src/org/chromium/content_shell/ShellLayoutTestUtils.java

Issue 2540603004: [Android] Redirect std{in,out,err} to sockets for layout tests. (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/android/BUILD.gn ('k') | content/shell/browser/layout_test/layout_test_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/android/java/src/org/chromium/content_shell/ShellLayoutTestUtils.java
diff --git a/content/shell/android/java/src/org/chromium/content_shell/ShellLayoutTestUtils.java b/content/shell/android/java/src/org/chromium/content_shell/ShellLayoutTestUtils.java
index 7a55269abdd2eae15ad0edadfadaf0aff0efc803..d308591b04324a0b1bed68f20b972b4b563e5c6c 100644
--- a/content/shell/android/java/src/org/chromium/content_shell/ShellLayoutTestUtils.java
+++ b/content/shell/android/java/src/org/chromium/content_shell/ShellLayoutTestUtils.java
@@ -4,10 +4,9 @@
package org.chromium.content_shell;
-import android.content.Context;
-
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace;
+import org.chromium.base.test.util.UrlUtils;
/**
* Utility methods used by content_shell for running Blink's layout tests on Android.
@@ -15,11 +14,10 @@ import org.chromium.base.annotations.JNINamespace;
@JNINamespace("content")
class ShellLayoutTestUtils {
/**
- * @return The directory in which the test files, for example FIFOs, can be stored.
+ * @return The directory in which test data is stored.
*/
- @SuppressWarnings("unused")
@CalledByNative
- private static String getApplicationFilesDirectory(Context appContext) {
- return appContext.getFilesDir().getAbsolutePath();
+ private static String getIsolatedTestRoot() {
+ return UrlUtils.getIsolatedTestRoot();
}
}
« no previous file with comments | « content/shell/android/BUILD.gn ('k') | content/shell/browser/layout_test/layout_test_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698