third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py - Issue 2540603004: [Android] Redirect std{in,out,err} to sockets for layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py

Issue 2540603004: [Android] Redirect std{in,out,err} to sockets for layout tests. (Closed)

Patch Set: Fix server_process_constructor name. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py

index f6003682e5c12ba894faabcedab71639227d9805..1b9731e513df900fa4b4662c6b1b5bdbdfe5fe9d 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py

@@ -219,7 +219,7 @@ class DriverTest(unittest.TestCase):

def test_stop_cleans_up_properly(self):

port = self.make_port()

- port._server_process_constructor = MockServerProcess

+ port.server_process_constructor = MockServerProcess

driver = Driver(port, 0, pixel_tests=True)

driver.start(True, [], None)

last_tmpdir = port.host.filesystem.last_tmpdir

@@ -229,7 +229,7 @@ class DriverTest(unittest.TestCase):

def test_two_starts_cleans_up_properly(self):

port = self.make_port()

- port._server_process_constructor = MockServerProcess

+ port.server_process_constructor = MockServerProcess

driver = Driver(port, 0, pixel_tests=True)

driver.start(True, [], None)

last_tmpdir = port.host.filesystem.last_tmpdir

@@ -238,7 +238,7 @@ class DriverTest(unittest.TestCase):

def test_start_actually_starts(self):

port = self.make_port()

- port._server_process_constructor = MockServerProcess

+ port.server_process_constructor = MockServerProcess

driver = Driver(port, 0, pixel_tests=True)

driver.start(True, [], None)

self.assertTrue(driver._server_process.started)