Move desugaring of super calls with trailing spread to one runtime call.

src/ast/ast-numbering.cc

Index: src/ast/ast-numbering.cc
diff --git a/src/ast/ast-numbering.cc b/src/ast/ast-numbering.cc
index c422744c6cc95f38f61f5f2e38ac4e021dc091b5..9d44fdbb21f842aadfc3ba3f16d00da2788dec39 100644
--- a/src/ast/ast-numbering.cc
+++ b/src/ast/ast-numbering.cc
@@ -394,9 +394,11 @@ void AstNumberingVisitor::VisitCompareOperation(CompareOperation* node) {
   ReserveFeedbackSlots(node);
 }
 
-
-void AstNumberingVisitor::VisitSpread(Spread* node) { UNREACHABLE(); }
-
+void AstNumberingVisitor::VisitSpread(Spread* node) {

[Benedikt Meurer, 2016/11/29 13:15:40]

Don't we need a DisableFullCodegenAndCrankshaft() call in here?

[petermarshall, 2016/11/29 13:32:27]

Hmmm currently the spread only ends up in the AST if it is a child of a
super-call node, meaning DisableFullCodegenAndCrankshaft() has already been
called, but it isn't possible to assert that here I don't think. Should we just
call it here again anyway, to be sure? Problem being that it could potentially
mask bugs in the future if a spread ends up in the AST when it shouldn't be.

[Benedikt Meurer, 2016/11/29 13:36:56]

I see, makes sense. Let's leave it this way.

+  IncrementNodeCount();
+  node->set_base_id(ReserveIdRange(Spread::num_ids()));
+  Visit(node->expression());
+}
 
 void AstNumberingVisitor::VisitEmptyParentheses(EmptyParentheses* node) {
   UNREACHABLE();