Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Side by Side Diff: src/ast/ast-numbering.cc

Issue 2540593003: Move desugaring of super calls with trailing spread to one runtime call. (Closed)
Patch Set: fix potential evaluation order issue Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/ast/ast-numbering.h" 5 #include "src/ast/ast-numbering.h"
6 6
7 #include "src/ast/ast.h" 7 #include "src/ast/ast.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 375 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 386
387 387
388 void AstNumberingVisitor::VisitCompareOperation(CompareOperation* node) { 388 void AstNumberingVisitor::VisitCompareOperation(CompareOperation* node) {
389 IncrementNodeCount(); 389 IncrementNodeCount();
390 node->set_base_id(ReserveIdRange(CompareOperation::num_ids())); 390 node->set_base_id(ReserveIdRange(CompareOperation::num_ids()));
391 Visit(node->left()); 391 Visit(node->left());
392 Visit(node->right()); 392 Visit(node->right());
393 ReserveFeedbackSlots(node); 393 ReserveFeedbackSlots(node);
394 } 394 }
395 395
396 396 void AstNumberingVisitor::VisitSpread(Spread* node) {
397 void AstNumberingVisitor::VisitSpread(Spread* node) { UNREACHABLE(); } 397 IncrementNodeCount();
398 398 // We can only get here from super calls currently.
399 DisableFullCodegenAndCrankshaft(kSuperReference);
400 node->set_base_id(ReserveIdRange(Spread::num_ids()));
401 Visit(node->expression());
402 }
399 403
400 void AstNumberingVisitor::VisitEmptyParentheses(EmptyParentheses* node) { 404 void AstNumberingVisitor::VisitEmptyParentheses(EmptyParentheses* node) {
401 UNREACHABLE(); 405 UNREACHABLE();
402 } 406 }
403 407
404 408
405 void AstNumberingVisitor::VisitForInStatement(ForInStatement* node) { 409 void AstNumberingVisitor::VisitForInStatement(ForInStatement* node) {
406 IncrementNodeCount(); 410 IncrementNodeCount();
407 DisableSelfOptimization(); 411 DisableSelfOptimization();
408 node->set_base_id(ReserveIdRange(ForInStatement::num_ids())); 412 node->set_base_id(ReserveIdRange(ForInStatement::num_ids()));
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
620 } 624 }
621 625
622 626
623 bool AstNumbering::Renumber(Isolate* isolate, Zone* zone, 627 bool AstNumbering::Renumber(Isolate* isolate, Zone* zone,
624 FunctionLiteral* function) { 628 FunctionLiteral* function) {
625 AstNumberingVisitor visitor(isolate, zone); 629 AstNumberingVisitor visitor(isolate, zone);
626 return visitor.Renumber(function); 630 return visitor.Renumber(function);
627 } 631 }
628 } // namespace internal 632 } // namespace internal
629 } // namespace v8 633 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698