Don't enter gesture event handling when a frame is detached.

Don't enter gesture event handling when a frame is detached.

Some code paths are unguarded for the case where we get events while shutting
down/detaching a Frame. With this patch we just early-out.

BUG=655306
Committed: https://crrev.com/8e8f0e5d7baf97c1229acf414d6749b0a16fc4e8
Cr-Commit-Position: refs/heads/master@{#434876}

[bokan, 2016-11-29 00:27:00]

Description was changed from

==========
Don't enter gesture event handling when a frame is detached.

Some code paths are unguarded for the case where we get events while shutting
down/detaching a Frame. With this patch we just early-out.

BUG=655306
==========

to

==========
Don't enter gesture event handling when a frame is detached.

Some code paths are unguarded for the case where we get events while shutting
down/detaching a Frame. With this patch we just early-out.

BUG=655306
==========

[bokan, 2016-11-29 00:27:01]

bokan@chromium.org changed reviewers:
+ dtapuska@chromium.org

[bokan, 2016-11-29 00:28:13]

This should fix the crashes seen in the bug. At some point, we should probably
get more disciplined about this and have a single entry point into event
handling that sets down some guarantees about object existance. As it is, we
ad-hoc check (sometimes repeatedly) various combinations of Frame, FrameView,
Document, etc.

[bokan, 2016-11-29 00:28:26]

The CQ bit was checked by bokan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 00:29:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2016-11-29 00:37:29]

On 2016/11/29 00:28:13, bokan wrote:
> This should fix the crashes seen in the bug. At some point, we should probably
> get more disciplined about this and have a single entry point into event
> handling that sets down some guarantees about object existance. As it is, we
> ad-hoc check (sometimes repeatedly) various combinations of Frame, FrameView,
> Document, etc.

LGTM can we open an issue regarding this? Probably sending it over for Navid is
a good idea.

[commit-bot: I haz the power, 2016-11-29 03:06:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 03:06:18]

Dry run: This issue passed the CQ dry run.

[bokan, 2016-11-29 03:46:06]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2016-11-29 03:46:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 03:51:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480391166093280,
"parent_rev": "c2a89116ff65632f68d54ca0e78e0641c2ba7b35", "commit_rev":
"347df43c3b67bfa8407dfc16dcc943fc9468bbcc"}

[commit-bot: I haz the power, 2016-11-29 03:51:41]

Description was changed from

==========
Don't enter gesture event handling when a frame is detached.

Some code paths are unguarded for the case where we get events while shutting
down/detaching a Frame. With this patch we just early-out.

BUG=655306
==========

to

==========
Don't enter gesture event handling when a frame is detached.

Some code paths are unguarded for the case where we get events while shutting
down/detaching a Frame. With this patch we just early-out.

BUG=655306
==========

[commit-bot: I haz the power, 2016-11-29 03:51:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 03:54:26]

Description was changed from

==========
Don't enter gesture event handling when a frame is detached.

Some code paths are unguarded for the case where we get events while shutting
down/detaching a Frame. With this patch we just early-out.

BUG=655306
==========

to

==========
Don't enter gesture event handling when a frame is detached.

Some code paths are unguarded for the case where we get events while shutting
down/detaching a Frame. With this patch we just early-out.

BUG=655306

Committed: https://crrev.com/8e8f0e5d7baf97c1229acf414d6749b0a16fc4e8
Cr-Commit-Position: refs/heads/master@{#434876}
==========

[commit-bot: I haz the power, 2016-11-29 03:54:27]

Patchset 2 (id:??) landed as
https://crrev.com/8e8f0e5d7baf97c1229acf414d6749b0a16fc4e8
Cr-Commit-Position: refs/heads/master@{#434876}