chrome/browser/safe_browsing/client_side_detection_host_unittest.cc - Issue 2540563002: Move SafeBrowsingUIManager::UnsafeResource to security_interstitials namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

Issue 2540563002: Move SafeBrowsingUIManager::UnsafeResource to security_interstitials namespace (Closed)

Patch Set: remove deps, sources for ios Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_host.cc ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page.h » ('j') | components/security_interstitials/OWNERS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

index bbe5c1a4855f92a7697661abcd8980d469499304..284b0d4ed9bd13f4b51f355c794b4e8f8dcd29e4 100644

--- a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

@@ -143,7 +143,8 @@ class MockSafeBrowsingUIManager : public SafeBrowsingUIManager {

// Helper function which calls OnBlockingPageComplete for this client

// object.

- void InvokeOnBlockingPageComplete(const UrlCheckCallback& callback) {

+ void InvokeOnBlockingPageComplete(

+ const security_interstitials::UnsafeResource::UrlCheckCallback& callback) {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

// Note: this will delete the client object in the case of the CsdClient

// implementation.

@@ -204,7 +205,7 @@ class MockBrowserFeatureExtractor : public BrowserFeatureExtractor {

class ClientSideDetectionHostTest : public ChromeRenderViewHostTestHarness {

public:

- typedef SafeBrowsingUIManager::UnsafeResource UnsafeResource;

+ typedef security_interstitials::UnsafeResource UnsafeResource;

void SetUp() override {

ChromeRenderViewHostTestHarness::SetUp();