Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2540553003: Fix Share extension strings. (Closed)

Created:
4 years ago by Olivier
Modified:
4 years ago
Reviewers:
gambard, sdefresne
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org, pkl (ping after 24h if needed), extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Share extension strings. Add "Add to" to the strings. Also add olivierrobin as owners of the extensions. BUG=661920 Committed: https://crrev.com/116adc1b2a6a1ca87a4ee0432d4e40167fd4bf98 Cr-Commit-Position: refs/heads/master@{#434967}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
A ios/chrome/share_extension/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/share_extension/strings/ios_share_extension_strings.grd View 1 chunk +4 lines, -7 lines 0 comments Download
A ios/chrome/today_extension/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Olivier
4 years ago (2016-11-29 08:59:41 UTC) #2
gambard
lgtm
4 years ago (2016-11-29 09:32:11 UTC) #3
sdefresne
lgtm
4 years ago (2016-11-29 12:29:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540553003/1
4 years ago (2016-11-29 12:57:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 13:07:16 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-29 13:09:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/116adc1b2a6a1ca87a4ee0432d4e40167fd4bf98
Cr-Commit-Position: refs/heads/master@{#434967}

Powered by Google App Engine
This is Rietveld 408576698