Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2540543002: [Devtools] Moved flatten children to children nodes instead of datagrid (Closed)
Patch Set: Merge branch 'master' into FLATEN_CHILDREN Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index 3865db6055602f5ab6d2839ed69cc7674172d6fa..5d428ae4e70916ef2a378ce0be6a95daaff08abd 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -504,6 +504,7 @@ Network.NetworkLogView = class extends UI.VBox {
}
_setupDataGrid() {
+ /** @type {!UI.SortableDataGrid} */
this._dataGrid = this._columns.dataGrid();
this._dataGrid.setRowContextMenuCallback(
(contextMenu, node) => this.handleContextMenuForRequest(contextMenu, node.request()));
@@ -520,7 +521,8 @@ Network.NetworkLogView = class extends UI.VBox {
* @param {!Event} event
*/
_dataGridMouseMove(event) {
- var node = this._dataGrid.dataGridNodeFromNode(event.target);
+ var node = /** @type {?Network.NetworkDataGridNode} */ (
+ this._dataGrid.dataGridNodeFromNode(/** @type {!Node} */ (event.target)));
var highlightInitiatorChain = event.shiftKey;
this._setHoveredNode(node, highlightInitiatorChain);
this._highlightInitiatorChain((highlightInitiatorChain && node) ? node.request() : null);
@@ -783,7 +785,7 @@ Network.NetworkLogView = class extends UI.VBox {
* @return {!Array<!Network.NetworkDataGridNode>}
*/
flatNodesList() {
- return this._dataGrid.flatNodesList();
+ return this._dataGrid.rootNode().flatChildren();
}
_refresh() {

Powered by Google App Engine
This is Rietveld 408576698