Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Unified Diff: chrome/browser/extensions/api/messaging/extension_message_port.cc

Issue 2540533002: [Extensions] Remove source/opener tab id from extension ports (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/messaging/extension_message_port.cc
diff --git a/chrome/browser/extensions/api/messaging/extension_message_port.cc b/chrome/browser/extensions/api/messaging/extension_message_port.cc
index 2e7f595275062100631e5b98fd508baff4370863..caf0f068ed47e1aea9300bdcbc86daa0b8cf9db2 100644
--- a/chrome/browser/extensions/api/messaging/extension_message_port.cc
+++ b/chrome/browser/extensions/api/messaging/extension_message_port.cc
@@ -99,7 +99,6 @@ ExtensionMessagePort::ExtensionMessagePort(
extension_id_(extension_id),
browser_context_(extension_process->GetBrowserContext()),
extension_process_(extension_process),
- opener_tab_id_(-1),
did_create_port_(false),
background_host_ptr_(nullptr),
frame_tracker_(new FrameTracker(this)) {
@@ -122,7 +121,6 @@ ExtensionMessagePort::ExtensionMessagePort(
extension_id_(extension_id),
browser_context_(rfh->GetProcess()->GetBrowserContext()),
extension_process_(nullptr),
- opener_tab_id_(-1),
did_create_port_(false),
background_host_ptr_(nullptr),
frame_tracker_(new FrameTracker(this)) {
@@ -203,10 +201,8 @@ void ExtensionMessagePort::DispatchOnConnect(
const GURL& source_url,
const std::string& tls_channel_id) {
ExtensionMsg_TabConnectionInfo source;
- if (source_tab) {
+ if (source_tab)
source.tab.Swap(source_tab.get());
- source.tab.GetInteger("id", &opener_tab_id_);
- }
source.frame_id = source_frame_id;
ExtensionMsg_ExternalConnectionInfo info;
@@ -228,7 +224,7 @@ void ExtensionMessagePort::DispatchOnDisconnect(
void ExtensionMessagePort::DispatchOnMessage(const Message& message) {
SendToPort(base::MakeUnique<ExtensionMsg_DeliverMessage>(
- MSG_ROUTING_NONE, port_id_, opener_tab_id_, message));
+ MSG_ROUTING_NONE, port_id_, message));
}
void ExtensionMessagePort::IncrementLazyKeepaliveCount() {
« no previous file with comments | « chrome/browser/extensions/api/messaging/extension_message_port.h ('k') | extensions/common/extension_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698