Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2540533002: [Extensions] Remove source/opener tab id from extension ports (Closed)

Created:
3 years, 11 months ago by Devlin
Modified:
3 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Remove source/opener tab id from extension ports The message parameter source_tab_id is no longer used; remove it. By extension, also remove the opener_tab_id_ property from ExtensionMessagePorts. BUG=667584 Committed: https://crrev.com/34f2af6b36662f9fed5bccae0460901493e2a608 Cr-Commit-Position: refs/heads/master@{#435538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M chrome/browser/extensions/api/messaging/extension_message_port.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/messaging/extension_message_port.cc View 4 chunks +2 lines, -6 lines 0 comments Download
M extensions/common/extension_messages.h View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/renderer/dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/extension_frame_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/extension_frame_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
Devlin
Antony, can you take a look? Daniel, can you stamp the messages?
3 years, 11 months ago (2016-11-30 19:32:36 UTC) #7
dcheng
rs lgtm for ipc
3 years, 11 months ago (2016-11-30 19:34:05 UTC) #8
asargent_no_longer_on_chrome
lgtm
3 years, 11 months ago (2016-12-01 00:29:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540533002/1
3 years, 11 months ago (2016-12-01 02:07:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-01 03:00:18 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2016-12-01 03:01:58 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34f2af6b36662f9fed5bccae0460901493e2a608
Cr-Commit-Position: refs/heads/master@{#435538}

Powered by Google App Engine
This is Rietveld 408576698