chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 2540523003: Use standardized accelerator-to-shortcut code for new backspace shortcut UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 2540523003: Use standardized accelerator-to-shortcut code for new backspace shortcut UI. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index 8c4984149ee471350c3ed779051cb7e614f97e69..f75bad6ba3693bdc704461a72aa5a30495588a6b 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -437,9 +437,9 @@ bool BrowserWindowCocoa::IsFullscreenBubbleVisible() const {

return false; // Currently only called from toolkit-views website_settings.

}

-void BrowserWindowCocoa::MaybeShowNewBackShortcutBubble(bool forward) {

+void BrowserWindowCocoa::MaybeShowNewBackShortcutBubble(int command_id) {

[controller_ exclusiveAccessController]->MaybeShowNewBackShortcutBubble(

- forward);

+ command_id);

}

void BrowserWindowCocoa::HideNewBackShortcutBubble() {