chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm - Issue 2540523003: Use standardized accelerator-to-shortcut code for new backspace shortcut UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm

Issue 2540523003: Use standardized accelerator-to-shortcut code for new backspace shortcut UI. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_window.h ('K') | « chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm

diff --git a/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm b/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm

index cbe83eba2422f154f8ba0a903fff38348e742f9b..bc454b8d5fd4a1dc762231c189abbc4b0b960235 100644

--- a/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm

+++ b/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm

@@ -40,7 +40,7 @@ void ExclusiveAccessController::Show() {

views_bubble_.reset(new ExclusiveAccessBubbleViews(this, url_, bubble_type_));

}

-void ExclusiveAccessController::MaybeShowNewBackShortcutBubble(bool forward) {

+void ExclusiveAccessController::MaybeShowNewBackShortcutBubble(int command_id) {

if (!new_back_shortcut_bubble_ || !new_back_shortcut_bubble_->IsVisible()) {

// Show the bubble at most five times.

PrefService* prefs = GetProfile()->GetPrefs();

@@ -67,7 +67,7 @@ void ExclusiveAccessController::MaybeShowNewBackShortcutBubble(bool forward) {

last_back_shortcut_press_time_ = base::TimeTicks();

}

- new_back_shortcut_bubble_->UpdateContent(forward);

+ new_back_shortcut_bubble_->UpdateContent(command_id);

}

void ExclusiveAccessController::HideNewBackShortcutBubble() {